Re: [PATCH v2 1/2] dt-bindings: iio: pressure: Add MS5637

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Adding `vdd-supply` as a strictly required property breaks backward compatibility for existing device trees.
--

commit 8073eb9fc3f96931b47510a0323c9f632b9db41f
Author: Louis Adamian <adamianlouis@gmail.com>

dt-bindings: iio: pressure: Add MS5637

Create meas,ms5637 devicetree binding and move existing devices from
trivial-devices.yaml. Explicit compatible strings are added for the
different sub-variants because each requires different constants for the
second-order temperature compensation formulas.

> diff --git a/Documentation/devicetree/bindings/iio/pressure/meas,ms5637.yaml b/Documentation/devicetree/bindings/iio/pressure/meas,ms5637.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/pressure/meas,ms5637.yaml

[ ... ]

> +properties:

[ ... ]

> +  vdd-supply:
> +    description: Regulator that provides power to the sensor
> +
> +required:
> +  - compatible
> +  - reg
> +  - vdd-supply

[Severity: High]
Does adding vdd-supply to the required list break backward compatibility for
existing device trees?

The generic compatibles like meas,ms5637 and meas,ms5803 were moved from
trivial-devices.yaml to this new standalone binding. In trivial-devices.yaml,
vdd-supply was not defined and additionalProperties was set to false.

This means any valid, existing device tree for these sensors strictly could
not have included a vdd-supply property without failing validation. By
unconditionally adding vdd-supply to the required list, existing device trees
in the wild will fail dtbs_check.

Furthermore, the corresponding Linux driver (drivers/iio/pressure/ms5637.c)
does not appear to fetch or use a regulator, confirming it is not functionally
required.

Should vdd-supply be omitted from the required list, or only made
conditionally required for newly introduced compatibles, to preserve the
Device Tree ABI?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260610020458.104818-1-adamianlouis@gmail.com?part=1