Re: [PATCH v3 3/5] KVM: x86: Expose Zhaoxin RNG2 CPUID feature

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing synchronization of tools/arch/x86/include/asm/cpufeatures.h.
--

commit 0ff90b8c977a44dc52de6838a89fc982a023995b
Author: Ewan Hai-oc <ewanhai-oc@zhaoxin.com>

KVM: x86: Expose Zhaoxin RNG2 CPUID feature

This commit advertises the Zhaoxin second-generation hardware RNG
to guests via CPUID 0xC0000001 EDX bits 22 and 23. It adds the
corresponding feature definitions and initializes them in the
capabilities list.

> diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h
> index 276e4ef90bd07..e264758d58e22 100644
> --- a/arch/x86/include/asm/cpufeatures.h
> +++ b/arch/x86/include/asm/cpufeatures.h
> @@ -150,6 +150,8 @@
>  #define X86_FEATURE_PHE_EN		( 5*32+11) /* "phe_en" PHE enabled */
>  #define X86_FEATURE_PMM			( 5*32+12) /* "pmm" PadLock Montgomery Multiplier */
>  #define X86_FEATURE_PMM_EN		( 5*32+13) /* "pmm_en" PMM enabled */
> +#define X86_FEATURE_RNG2		( 5*32+22) /* "rng2" RNG v2 */
> +#define X86_FEATURE_RNG2_EN		( 5*32+23) /* "rng2_en" RNG2 enabled */

[Severity: Low]
Does this change also need to be synchronized to
tools/arch/x86/include/asm/cpufeatures.h? 

Leaving the tools header unsynchronized typically results in a build
warning from tools/perf/check-headers.sh when checking for divergences.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260610023512.3690734-1-ewanhai-oc@zhaoxin.com?part=3