Re: [PATCH v3 4/5] KVM: x86: Expose Zhaoxin PHE2 CPUID feature

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch adds X86_FEATURE_PHE2 and X86_FEATURE_PHE2_EN to arch/x86/include/asm/cpufeatures.h but fails to update the corresponding tools header tools/arch/x86/include/asm/cpufeatures.h.
--

commit 3f9973df29d33e555520e65352e2ad0d4e602e77
Author: Ewan Hai-oc <ewanhai-oc@zhaoxin.com>

KVM: x86: Expose Zhaoxin PHE2 CPUID feature

This commit advertises the Zhaoxin PadLock Hash Engine v2 to guests via
CPUID 0xC0000001 EDX bits 25 and 26. It exposes unprivileged instructions
for SHA-384 and SHA-512 support.

> diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h
> index e264758d58e22..3702d7a30ae61 100644
> --- a/arch/x86/include/asm/cpufeatures.h
> +++ b/arch/x86/include/asm/cpufeatures.h
> @@ -152,6 +152,8 @@
>  #define X86_FEATURE_PMM_EN		( 5*32+13) /* "pmm_en" PMM enabled */
>  #define X86_FEATURE_RNG2		( 5*32+22) /* "rng2" RNG v2 */
>  #define X86_FEATURE_RNG2_EN		( 5*32+23) /* "rng2_en" RNG2 enabled */
> +#define X86_FEATURE_PHE2		( 5*32+25) /* "phe2" PadLock Hash Engine v2 */
> +#define X86_FEATURE_PHE2_EN		( 5*32+26) /* "phe2_en" PHE2 enabled */

[Severity: Low]
Is it necessary to synchronize this addition with the tooling headers?

Adding new feature bits to arch/x86/include/asm/cpufeatures.h without also
mirroring them to tools/arch/x86/include/asm/cpufeatures.h usually causes
check-headers.sh to emit a build warning in the tools/perf tree.

Could this patch include the update to the tools directory copy to prevent
these warnings?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260610023512.3690734-1-ewanhai-oc@zhaoxin.com?part=4