[chrome-os:chromeos-6.6 31/31] drivers/hid/spi-hid/spi-hid-of-ilitek.c:3274:6: warning: no previous prototype for function 'ili_node_init'

[chrome-os:chromeos-6.6 31/31] drivers/hid/spi-hid/spi-hid-of-ilitek.c:3274:6: warning: no previous prototype for function 'ili_node_init'

[kernel test robot]

tree:   https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-6.6
head:   a4d01e77dd885e0545ecd445e2facf156ddf42f5
commit: 0323b36c9b64eac74e144f67c5758176f7f881d1 [31/31] CHROMIUM: HID: spi-hid: Add Ilitek MP test support in SPI-HID framework
config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20260610/202606100327.74ZKAHMu-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project 7917772d7d61384696c61102c08c2ea158e610fa)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260610/202606100327.74ZKAHMu-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202606100327.74ZKAHMu-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/hid/spi-hid/spi-hid-of-ilitek.c:513:5: warning: no previous prototype for function 'ili_spi_ms_register_read' [-Wmissing-prototypes]
     513 | int ili_spi_ms_register_read(u32 addr, u32 *data, int len, u8 msmode)
         |     ^
   drivers/hid/spi-hid/spi-hid-of-ilitek.c:513:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     513 | int ili_spi_ms_register_read(u32 addr, u32 *data, int len, u8 msmode)
         | ^
         | static 
   drivers/hid/spi-hid/spi-hid-of-ilitek.c:694:5: warning: no previous prototype for function 'ili_ic_code_reset' [-Wmissing-prototypes]
     694 | int ili_ic_code_reset(bool mcu)
         |     ^
   drivers/hid/spi-hid/spi-hid-of-ilitek.c:694:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     694 | int ili_ic_code_reset(bool mcu)
         | ^
         | static 
   drivers/hid/spi-hid/spi-hid-of-ilitek.c:2625:5: warning: no previous prototype for function 'ili_spi_write_then_read_split' [-Wmissing-prototypes]
    2625 | int ili_spi_write_then_read_split(struct spi_device *spi,
         |     ^
   drivers/hid/spi-hid/spi-hid-of-ilitek.c:2625:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
    2625 | int ili_spi_write_then_read_split(struct spi_device *spi,
         | ^
         | static 
>> drivers/hid/spi-hid/spi-hid-of-ilitek.c:3274:6: warning: no previous prototype for function 'ili_node_init' [-Wmissing-prototypes]
    3274 | void ili_node_init(void)
         |      ^
   drivers/hid/spi-hid/spi-hid-of-ilitek.c:3274:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
    3274 | void ili_node_init(void)
         | ^
         | static 
>> drivers/hid/spi-hid/spi-hid-of-ilitek.c:3297:6: warning: no previous prototype for function 'ili_node_remove' [-Wmissing-prototypes]
    3297 | void ili_node_remove(struct ilitek_ts_hid_data *ts)
         |      ^
   drivers/hid/spi-hid/spi-hid-of-ilitek.c:3297:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
    3297 | void ili_node_remove(struct ilitek_ts_hid_data *ts)
         | ^
         | static 
   5 warnings generated.


vim +/ili_node_init +3274 drivers/hid/spi-hid/spi-hid-of-ilitek.c

  3273	
> 3274	void ili_node_init(void)
  3275	{
  3276		int i = 0;
  3277	
  3278		proc_dir_ilitek = proc_mkdir("ilitek", NULL);
  3279	
  3280		for (; i < ARRAY_SIZE(iliproc); i++) {
  3281			iliproc[i].node = proc_create(
  3282									iliproc[i].name,
  3283									0644,
  3284									proc_dir_ilitek,
  3285									iliproc[i].fops);
  3286	
  3287			if (iliproc[i].node == NULL) {
  3288				iliproc[i].isCreated = false;
  3289				ILI_ERR("Failed to create %s under /proc\n", iliproc[i].name);
  3290			} else {
  3291				iliproc[i].isCreated = true;
  3292				ILI_INFO("Succeed to create %s under /proc\n", iliproc[i].name);
  3293			}
  3294		}
  3295	}
  3296	
> 3297	void ili_node_remove(struct ilitek_ts_hid_data *ts)
  3298	{
  3299		int i = 0;
  3300	
  3301		/* Remove nodes under /proc/ilitek */
  3302		for (; i < ARRAY_SIZE(iliproc); i++) {
  3303			if (iliproc[i].isCreated && iliproc[i].node) {
  3304				proc_remove(iliproc[i].node);
  3305				iliproc[i].node = NULL;
  3306				iliproc[i].isCreated = false;
  3307			}
  3308		}
  3309	
  3310		if (proc_dir_ilitek) {
  3311			proc_remove(proc_dir_ilitek);
  3312			proc_dir_ilitek = NULL;
  3313		}
  3314	
  3315		ILI_INFO("Remove TP filesystem node.\n");
  3316	}
  3317	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki