[PATCH] nvme: make some sysfs diagnostic structures static

[PATCH] nvme: make some sysfs diagnostic structures static

[John Garry]

Building with C=1 generates the following warnings:
drivers/nvme/host/sysfs.c:397:25: warning: symbol 'dev_attr_io_errors' was not declared. Should it be static?
drivers/nvme/host/sysfs.c:444:30: warning: symbol 'nvme_ns_diag_attr_group' was not declared. Should it be static?
drivers/nvme/host/sysfs.c:1150:25: warning: symbol 'dev_attr_adm_errors' was not declared. Should it be static?

Make those structures static.

Signed-off-by: John Garry <john.g.garry@oracle.com>

diff --git a/drivers/nvme/host/sysfs.c b/drivers/nvme/host/sysfs.c
index 933a5adfb7af5..75b2d69b59578 100644
--- a/drivers/nvme/host/sysfs.c
+++ b/drivers/nvme/host/sysfs.c
@@ -394,7 +394,7 @@ static ssize_t nvme_io_errors_store(struct device *dev,
 	return count;
 }
 
-struct device_attribute dev_attr_io_errors =
+static struct device_attribute dev_attr_io_errors =
 	__ATTR(command_error_count, 0644,
 		nvme_io_errors_show, nvme_io_errors_store);
 
@@ -441,7 +441,7 @@ static umode_t nvme_ns_diag_attrs_are_visible(struct kobject *kobj,
 	return a->mode;
 }
 
-const struct attribute_group nvme_ns_diag_attr_group = {
+static const struct attribute_group nvme_ns_diag_attr_group = {
 	.name		= "diag",
 	.attrs		= nvme_ns_diag_attrs,
 	.is_visible	= nvme_ns_diag_attrs_are_visible,
@@ -1147,7 +1147,7 @@ static ssize_t nvme_adm_errors_store(struct device *dev,
 	return count;
 }
 
-struct device_attribute dev_attr_adm_errors =
+static struct device_attribute dev_attr_adm_errors =
 	__ATTR(command_error_count, 0644,
 		nvme_adm_errors_show, nvme_adm_errors_store);
 
-- 
2.43.5

Re: [PATCH] nvme: make some sysfs diagnostic structures static

[Nilay Shroff]

On 6/10/26 2:23 PM, John Garry wrote:
> Building with C=1 generates the following warnings:
> drivers/nvme/host/sysfs.c:397:25: warning: symbol 'dev_attr_io_errors' was not declared. Should it be static?
> drivers/nvme/host/sysfs.c:444:30: warning: symbol 'nvme_ns_diag_attr_group' was not declared. Should it be static?
> drivers/nvme/host/sysfs.c:1150:25: warning: symbol 'dev_attr_adm_errors' was not declared. Should it be static?
> 
> Make those structures static.
> 
> Signed-off-by: John Garry <john.g.garry@oracle.com>
> 
> diff --git a/drivers/nvme/host/sysfs.c b/drivers/nvme/host/sysfs.c
> index 933a5adfb7af5..75b2d69b59578 100644
> --- a/drivers/nvme/host/sysfs.c
> +++ b/drivers/nvme/host/sysfs.c
> @@ -394,7 +394,7 @@ static ssize_t nvme_io_errors_store(struct device *dev,
>   	return count;
>   }
>   
> -struct device_attribute dev_attr_io_errors =
> +static struct device_attribute dev_attr_io_errors =
>   	__ATTR(command_error_count, 0644,
>   		nvme_io_errors_show, nvme_io_errors_store);
>   
> @@ -441,7 +441,7 @@ static umode_t nvme_ns_diag_attrs_are_visible(struct kobject *kobj,
>   	return a->mode;
>   }
>   
> -const struct attribute_group nvme_ns_diag_attr_group = {
> +static const struct attribute_group nvme_ns_diag_attr_group = {
>   	.name		= "diag",
>   	.attrs		= nvme_ns_diag_attrs,
>   	.is_visible	= nvme_ns_diag_attrs_are_visible,
> @@ -1147,7 +1147,7 @@ static ssize_t nvme_adm_errors_store(struct device *dev,
>   	return count;
>   }
>   
> -struct device_attribute dev_attr_adm_errors =
> +static struct device_attribute dev_attr_adm_errors =
>   	__ATTR(command_error_count, 0644,
>   		nvme_adm_errors_show, nvme_adm_errors_store);
>   
BTW, kernel test robot also reported this same issue here:
https://lore.kernel.org/oe-kbuild-all/202606101329.T3zXNqdy-lkp@intel.com/

So you may want to add closes tag pointing to the above link. Otherwise,
this change looks good to me.

Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>

Re: [PATCH] nvme: make some sysfs diagnostic structures static

[John Garry]

>>   }
>> -struct device_attribute dev_attr_adm_errors =
>> +static struct device_attribute dev_attr_adm_errors =
>>       __ATTR(command_error_count, 0644,
>>           nvme_adm_errors_show, nvme_adm_errors_store);
> BTW, kernel test robot also reported this same issue here:
> https://urldefense.com/v3/__https://lore.kernel.org/oe-kbuild- 
> all/202606101329.T3zXNqdy-lkp@intel.com/__;!!ACWV5N9M2RV99hQ! 
> P5UdkxQBbB6XuNloxfIJKNALsPKk8vSXQENG4khm- 
> SufSw1QG_Ndga5ZvcKhtCypHWJDcNkaE1KDvZZ8pO8$
> So you may want to add closes tag pointing to the above link. Otherwise,
> this change looks good to me.
> 

I would not have noticed that, but here is the necessary tag anyway:

Closes: 
https://lore.kernel.org/oe-kbuild-all/202606101329.T3zXNqdy-lkp@intel.com/

> Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>

Cheers

Re: [PATCH] nvme: make some sysfs diagnostic structures static

[Christoph Hellwig]

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Re: [PATCH] nvme: make some sysfs diagnostic structures static

[Keith Busch]

On Wed, Jun 10, 2026 at 08:53:32AM +0000, John Garry wrote:
> Building with C=1 generates the following warnings:
> drivers/nvme/host/sysfs.c:397:25: warning: symbol 'dev_attr_io_errors' was not declared. Should it be static?
> drivers/nvme/host/sysfs.c:444:30: warning: symbol 'nvme_ns_diag_attr_group' was not declared. Should it be static?
> drivers/nvme/host/sysfs.c:1150:25: warning: symbol 'dev_attr_adm_errors' was not declared. Should it be static?
> 
> Make those structures static.

Thanks, applied to nvme-7.2.