From: Rosen Penev <rosenp@gmail.com>
To: dmaengine@vger.kernel.org
Cc: Vinod Koul <vkoul@kernel.org>, Frank Li <Frank.Li@kernel.org>,
Zhang Wei <zw@zh-kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
linux-kernel@vger.kernel.org (open list),
linuxppc-dev@lists.ozlabs.org (open list:FREESCALE DMA DRIVER),
llvm@lists.linux.dev (open list:CLANG/LLVM BUILD
SUPPORT:Keyword:\b(?i:clang|llvm)\b)
Subject: [PATCHv4 11/15] dmaengine: fsldma: convert channel allocation to devm_kzalloc()
Date: Wed, 10 Jun 2026 20:52:41 -0700 [thread overview]
Message-ID: <20260611035245.13439-12-rosenp@gmail.com> (raw)
In-Reply-To: <20260611035245.13439-1-rosenp@gmail.com>
Convert fsl_dma_chan_probe from kzalloc_obj() to devm_kzalloc(), tying
the channel lifetime to the parent DMA device. Remove kfree(chan) in both
the probe error path and the remove function.
Assisted-by: opencode:big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/dma/fsldma.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
index e4a3315a7d9d..0df09789187d 100644
--- a/drivers/dma/fsldma.c
+++ b/drivers/dma/fsldma.c
@@ -1114,11 +1114,9 @@ static int fsl_dma_chan_probe(struct fsldma_device *fdev,
int err;
/* alloc channel */
- chan = kzalloc_obj(*chan);
- if (!chan) {
- err = -ENOMEM;
- goto out_return;
- }
+ chan = devm_kzalloc(fdev->dev, sizeof(*chan), GFP_KERNEL);
+ if (!chan)
+ return -ENOMEM;
/* ioremap registers for use */
chan->regs = of_iomap(node, 0);
@@ -1200,9 +1198,6 @@ static int fsl_dma_chan_probe(struct fsldma_device *fdev,
out_iounmap_regs:
iounmap(chan->regs);
-out_free_chan:
- kfree(chan);
-out_return:
return err;
}
@@ -1215,7 +1210,6 @@ static void fsl_dma_chan_remove(struct fsldma_chan *chan)
tasklet_kill(&chan->tasklet);
list_del(&chan->common.device_node);
iounmap(chan->regs);
- kfree(chan);
}
static void fsldma_device_release(struct dma_device *dma_dev);
--
2.54.0
next prev parent reply other threads:[~2026-06-11 3:53 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 3:52 [PATCHv4 00/15] dmaengine: fsldma: devm conversion, fixups, and cleanups Rosen Penev
2026-06-11 3:52 ` [PATCHv4 01/15] dmaengine: fsldma: kill tasklet before removing channel Rosen Penev
2026-06-11 4:05 ` sashiko-bot
2026-06-11 3:52 ` [PATCHv4 02/15] dmaengine: fsldma: drop desc_lock before invoking client callback Rosen Penev
2026-06-11 4:06 ` sashiko-bot
2026-06-11 15:19 ` Frank Li
2026-06-11 16:30 ` Rosen Penev
2026-06-11 3:52 ` [PATCHv4 03/15] dmaengine: fsldma: halt DMA engine before freeing resources Rosen Penev
2026-06-11 3:52 ` [PATCHv4 04/15] dmaengine: fsldma: provide device_release callback Rosen Penev
2026-06-11 4:02 ` sashiko-bot
2026-06-11 15:28 ` Frank Li
2026-06-11 3:52 ` [PATCHv4 05/15] dmaengine: fsldma: check dma_async_device_register() return value Rosen Penev
2026-06-11 4:03 ` sashiko-bot
2026-06-11 15:29 ` Frank Li
2026-06-11 3:52 ` [PATCHv4 06/15] dmaengine: fsldma: fix probe error path not freeing IRQs Rosen Penev
2026-06-11 15:30 ` Frank Li
2026-06-11 3:52 ` [PATCHv4 07/15] dmaengine: fsldma: fix request_irqs unwind freeing unregistered IRQ Rosen Penev
2026-06-11 4:03 ` sashiko-bot
2026-06-11 15:31 ` Frank Li
2026-06-11 3:52 ` [PATCHv4 08/15] dmaengine: fsldma: convert to platform_get_irq_optional() Rosen Penev
2026-06-11 3:52 ` [PATCHv4 09/15] dmaengine: fsldma: use devm_kzalloc() to simplify code Rosen Penev
2026-06-11 15:34 ` Frank Li
2026-06-11 3:52 ` [PATCHv4 10/15] dmaengine: fsldma: use devm_platform_ioremap_resource() Rosen Penev
2026-06-11 15:35 ` Frank Li
2026-06-11 3:52 ` Rosen Penev [this message]
2026-06-11 15:36 ` [PATCHv4 11/15] dmaengine: fsldma: convert channel allocation to devm_kzalloc() Frank Li
2026-06-11 16:08 ` Rosen Penev
2026-06-11 16:32 ` Frank Li
2026-06-11 16:36 ` Rosen Penev
2026-06-11 3:52 ` [PATCHv4 12/15] dmaengine: fsldma: use devm_of_iomap() to simplify code Rosen Penev
2026-06-11 15:37 ` Frank Li
2026-06-11 3:52 ` [PATCHv4 13/15] dmaengine: fsldma: replace irq_of_parse_and_map with of_irq_get Rosen Penev
2026-06-11 4:07 ` sashiko-bot
2026-06-11 15:39 ` Frank Li
2026-06-11 3:52 ` [PATCHv4 14/15] dmaengine: fsldma: replace ppc-specific accessors with portable generic ones Rosen Penev
2026-06-11 15:42 ` Frank Li
2026-06-11 3:52 ` [PATCHv4 15/15] dmaengine: fsldma: fix kernel-doc param names to match function signatures Rosen Penev
2026-06-11 15:45 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260611035245.13439-12-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=Frank.Li@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=vkoul@kernel.org \
--cc=zw@zh-kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.