All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: ville.syrjala@linux.intel.com, arun.r.murthy@intel.com,
	jani.nikula@linux.intel.com,
	Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Subject: [PATCH v4 03/12] drm/i915/intel_dip: Add check for DP encoder
Date: Thu, 11 Jun 2026 13:03:05 +0530	[thread overview]
Message-ID: <20260611073316.1439306-4-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20260611073316.1439306-1-ankit.k.nautiyal@intel.com>

At the moment, the common register for programming Transmission line for
Extended Metadata Packet and Adaptive-Sync Secondary Data Packet
(EMP_AS_SDP_TL) is only used to program Adaptive-Sync SDP (AS SDP).

Since VRR and Video Timing Extended Metadat Packet (VTEMP) are not yet
implemented for HDMI, add an explicit check to write the register only
for DP encoders (that may use AS SDP) and reset the register for non-DP
encoders.

In subsequent changes, instead of directly writing the value,
appropriate helpers will be called, that will supply the transmission line
for these packets.

Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dip.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dip.c b/drivers/gpu/drm/i915/display/intel_dip.c
index 2e2bdb2b199c..450a599b5053 100644
--- a/drivers/gpu/drm/i915/display/intel_dip.c
+++ b/drivers/gpu/drm/i915/display/intel_dip.c
@@ -26,14 +26,19 @@ void intel_dip_write_emp_as_sdp_tl(const struct intel_crtc_state *crtc_state)
 {
 	struct intel_display *display = to_intel_display(crtc_state);
 	enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
+	u32 transmission_line = 0;
 
 	if (!HAS_EMP_AS_SDP_TL(display))
 		return;
 	/*
-	 * Since currently we support VRR only for DP/eDP, so this is programmed
-	 * only for Adaptive Sync SDP to Vsync start.
+	 * Since currently we support VRR only for DP/eDP, program the register
+	 * for Adaptive Sync SDP using vsync start. For non-DP encoders,
+	 * the register is reset to 0.
 	 */
+	if (intel_crtc_has_dp_encoder(crtc_state))
+		transmission_line = crtc_state->vrr.vsync_start;
+
 	intel_de_write(display,
 		       EMP_AS_SDP_TL(display, cpu_transcoder),
-		       EMP_AS_SDP_DB_TL(crtc_state->vrr.vsync_start));
+		       EMP_AS_SDP_DB_TL(transmission_line));
 }
-- 
2.45.2


  parent reply	other threads:[~2026-06-11  7:51 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-11  7:33 [PATCH v4 00/12] Add support for Common SDP Transmission Line Ankit Nautiyal
2026-06-11  7:33 ` [PATCH v4 01/12] drm/i915/dip: Add new file to handle Data Island Packet hardware Ankit Nautiyal
2026-08-27  6:46   ` Kandpal, Suraj
2026-06-11  7:33 ` [PATCH v4 02/12] drm/i915/vrr: Use the helper to write EMP_AS_SDP_TL register Ankit Nautiyal
2026-08-27  6:49   ` Kandpal, Suraj
2026-06-11  7:33 ` Ankit Nautiyal [this message]
2026-08-27  8:29   ` [PATCH v4 03/12] drm/i915/intel_dip: Add check for DP encoder Kandpal, Suraj
2026-06-11  7:33 ` [PATCH v4 04/12] drm/i915/dp: Add helper to get AS SDP Transmission Line Ankit Nautiyal
2026-09-01  2:55   ` Kandpal, Suraj
2026-06-11  7:33 ` [PATCH v4 05/12] drm/i915/display: Add crtc state for DIP transmission lines Ankit Nautiyal
2026-09-01  2:56   ` Kandpal, Suraj
2026-09-08 15:35   ` Jani Nikula
2026-09-10  2:44     ` Nautiyal, Ankit K
2026-06-11  7:33 ` [PATCH v4 06/12] drm/i915/dip: Store and use AS SDP transmission line from crtc state Ankit Nautiyal
2026-09-01  3:03   ` Kandpal, Suraj
2026-09-08  6:14     ` Nautiyal, Ankit K
2026-06-11  7:33 ` [PATCH v4 07/12] drm/i915/nvl: Add register definitions for common SDP Transmission Line Ankit Nautiyal
2026-06-11  7:33 ` [PATCH v4 08/12] drm/i915/display: Add HAS_COMMON_SDP_TL macro Ankit Nautiyal
2026-09-01  3:26   ` Kandpal, Suraj
2026-06-11  7:33 ` [PATCH v4 09/12] drm/i915/dp: Store SDP transmission lines in crtc_state Ankit Nautiyal
2026-09-01  3:30   ` Kandpal, Suraj
2026-09-08  6:25     ` Nautiyal, Ankit K
2026-06-11  7:33 ` [PATCH v4 10/12] drm/i915/dp: Introduce helpers to enable/disable CMN SDP Transmission line Ankit Nautiyal
2026-06-11  7:33 ` [PATCH v4 11/12] drm/i915/dip: Enable Common " Ankit Nautiyal
2026-06-11  7:33 ` [PATCH v4 12/12] drm/i915/display: Dump DIP Transmission lines Ankit Nautiyal
2026-06-11  8:37 ` ✗ CI.checkpatch: warning for Add support for Common SDP Transmission Line (rev4) Patchwork
2026-06-11  8:40 ` ✓ CI.KUnit: success " Patchwork
2026-06-11  9:02 ` ✓ i915.CI.BAT: " Patchwork
2026-06-11 10:01 ` ✓ Xe.CI.BAT: " Patchwork
2026-06-11 19:07 ` ✓ Xe.CI.FULL: " Patchwork
2026-06-12  4:59 ` ✗ i915.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260611073316.1439306-4-ankit.k.nautiyal@intel.com \
    --to=ankit.k.nautiyal@intel.com \
    --cc=arun.r.murthy@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.