* [PATCH v2] dt-bindings: pinctrl: qcom,pmic-gpio: Add Qualcomm PMK7750
@ 2026-06-11 11:07 Krzysztof Kozlowski
2026-06-11 11:12 ` sashiko-bot
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-06-11 11:07 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski, Abel Vesa
Document Qualcomm PMK7750 GPIO used with Eliza SoC. PMIC is almost the
same as PMK8550, thus compatible with it.
Cc: Abel Vesa <abel.vesa@oss.qualcomm.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
Changes in v2:
1. Add fallback compatible.
---
.../bindings/pinctrl/qcom,pmic-gpio.yaml | 152 +++++++++---------
1 file changed, 79 insertions(+), 73 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
index 386c31e9c52b..f656c836896f 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
@@ -15,79 +15,85 @@ description:
properties:
compatible:
- items:
- - enum:
- - qcom,pm2250-gpio
- - qcom,pm660-gpio
- - qcom,pm660l-gpio
- - qcom,pm6125-gpio
- - qcom,pm6150-gpio
- - qcom,pm6150l-gpio
- - qcom,pm6350-gpio
- - qcom,pm6450-gpio
- - qcom,pm7250b-gpio
- - qcom,pm7325-gpio
- - qcom,pm7550-gpio
- - qcom,pm7550ba-gpio
- - qcom,pm8005-gpio
- - qcom,pm8018-gpio
- - qcom,pm8019-gpio
- - qcom,pm8038-gpio
- - qcom,pm8058-gpio
- - qcom,pm8150-gpio
- - qcom,pm8150b-gpio
- - qcom,pm8150l-gpio
- - qcom,pm8226-gpio
- - qcom,pm8350-gpio
- - qcom,pm8350b-gpio
- - qcom,pm8350c-gpio
- - qcom,pm8450-gpio
- - qcom,pm8550-gpio
- - qcom,pm8550b-gpio
- - qcom,pm8550ve-gpio
- - qcom,pm8550vs-gpio
- - qcom,pm8916-gpio
- - qcom,pm8917-gpio
- - qcom,pm8921-gpio
- - qcom,pm8937-gpio
- - qcom,pm8941-gpio
- - qcom,pm8950-gpio
- - qcom,pm8953-gpio
- - qcom,pm8994-gpio
- - qcom,pm8998-gpio
- - qcom,pma8084-gpio
- - qcom,pmc8180-gpio
- - qcom,pmc8180c-gpio
- - qcom,pmc8380-gpio
- - qcom,pmcx0102-gpio
- - qcom,pmd8028-gpio
- - qcom,pmh0101-gpio
- - qcom,pmh0104-gpio
- - qcom,pmh0110-gpio
- - qcom,pmi632-gpio
- - qcom,pmi8950-gpio
- - qcom,pmi8994-gpio
- - qcom,pmi8998-gpio
- - qcom,pmih0108-gpio
- - qcom,pmiv0104-gpio
- - qcom,pmk8350-gpio
- - qcom,pmk8550-gpio
- - qcom,pmk8850-gpio
- - qcom,pmm8155au-gpio
- - qcom,pmm8654au-gpio
- - qcom,pmp8074-gpio
- - qcom,pmr735a-gpio
- - qcom,pmr735b-gpio
- - qcom,pmr735d-gpio
- - qcom,pms405-gpio
- - qcom,pmx55-gpio
- - qcom,pmx65-gpio
- - qcom,pmx75-gpio
- - qcom,pmxr2230-gpio
-
- - enum:
- - qcom,spmi-gpio
- - qcom,ssbi-gpio
+ oneOf:
+ - items:
+ - enum:
+ - qcom,pm2250-gpio
+ - qcom,pm660-gpio
+ - qcom,pm660l-gpio
+ - qcom,pm6125-gpio
+ - qcom,pm6150-gpio
+ - qcom,pm6150l-gpio
+ - qcom,pm6350-gpio
+ - qcom,pm6450-gpio
+ - qcom,pm7250b-gpio
+ - qcom,pm7325-gpio
+ - qcom,pm7550-gpio
+ - qcom,pm7550ba-gpio
+ - qcom,pm8005-gpio
+ - qcom,pm8018-gpio
+ - qcom,pm8019-gpio
+ - qcom,pm8038-gpio
+ - qcom,pm8058-gpio
+ - qcom,pm8150-gpio
+ - qcom,pm8150b-gpio
+ - qcom,pm8150l-gpio
+ - qcom,pm8226-gpio
+ - qcom,pm8350-gpio
+ - qcom,pm8350b-gpio
+ - qcom,pm8350c-gpio
+ - qcom,pm8450-gpio
+ - qcom,pm8550-gpio
+ - qcom,pm8550b-gpio
+ - qcom,pm8550ve-gpio
+ - qcom,pm8550vs-gpio
+ - qcom,pm8916-gpio
+ - qcom,pm8917-gpio
+ - qcom,pm8921-gpio
+ - qcom,pm8937-gpio
+ - qcom,pm8941-gpio
+ - qcom,pm8950-gpio
+ - qcom,pm8953-gpio
+ - qcom,pm8994-gpio
+ - qcom,pm8998-gpio
+ - qcom,pma8084-gpio
+ - qcom,pmc8180-gpio
+ - qcom,pmc8180c-gpio
+ - qcom,pmc8380-gpio
+ - qcom,pmcx0102-gpio
+ - qcom,pmd8028-gpio
+ - qcom,pmh0101-gpio
+ - qcom,pmh0104-gpio
+ - qcom,pmh0110-gpio
+ - qcom,pmi632-gpio
+ - qcom,pmi8950-gpio
+ - qcom,pmi8994-gpio
+ - qcom,pmi8998-gpio
+ - qcom,pmih0108-gpio
+ - qcom,pmiv0104-gpio
+ - qcom,pmk8350-gpio
+ - qcom,pmk7750-gpio
+ - qcom,pmk8550-gpio
+ - qcom,pmk8850-gpio
+ - qcom,pmm8155au-gpio
+ - qcom,pmm8654au-gpio
+ - qcom,pmp8074-gpio
+ - qcom,pmr735a-gpio
+ - qcom,pmr735b-gpio
+ - qcom,pmr735d-gpio
+ - qcom,pms405-gpio
+ - qcom,pmx55-gpio
+ - qcom,pmx65-gpio
+ - qcom,pmx75-gpio
+ - qcom,pmxr2230-gpio
+ - enum:
+ - qcom,spmi-gpio
+ - qcom,ssbi-gpio
+ - items:
+ - enum:
+ - qcom,pmk7750-gpio
+ - const: qcom,pmk8550-gpio
+ - const: qcom,spmi-gpio
reg:
maxItems: 1
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] dt-bindings: pinctrl: qcom,pmic-gpio: Add Qualcomm PMK7750
2026-06-11 11:07 [PATCH v2] dt-bindings: pinctrl: qcom,pmic-gpio: Add Qualcomm PMK7750 Krzysztof Kozlowski
@ 2026-06-11 11:12 ` sashiko-bot
2026-06-11 12:24 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: sashiko-bot @ 2026-06-11 11:12 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: robh, devicetree, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Adding `qcom,pmk7750-gpio` to the standalone enum list without updating the corresponding `allOf` conditional blocks causes a schema validation hole. When used standalone, the compatible string bypasses generation-specific constraints (such as `gpio-line-names` and `gpio-reserved-ranges`) that apply to the PMK8550 generation it claims to be compatible with.
--
commit c696fcf54d49ee1cd5093d304f55dcf2aa2358e3
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
dt-bindings: pinctrl: qcom,pmic-gpio: Add Qualcomm PMK7750
Document Qualcomm PMK7750 GPIO used with Eliza SoC. PMIC is almost the
same as PMK8550, thus compatible with it.
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> index 386c31e9c52b8..f656c836896f5 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> @@ -15,79 +15,85 @@ description:
>
> properties:
> compatible:
> - items:
> - - enum:
[ ... ]
> + oneOf:
> + - items:
> + - enum:
[ ... ]
> + - qcom,pmiv0104-gpio
> + - qcom,pmk8350-gpio
> + - qcom,pmk7750-gpio
[Severity: Medium]
Since qcom,pmk7750-gpio is added here to the standalone enum list, won't
standalone usage bypass the generation-specific constraints (such as the
gpio-line-names limit) defined in the allOf conditional block for the
PMK8550 generation?
Should qcom,pmk7750-gpio also be added to the allOf conditional block
containing qcom,pmk8550-gpio, or should it be removed from this standalone
enum list if the fallback is always expected?
> + - qcom,pmk8550-gpio
> + - qcom,pmk8850-gpio
[ ... ]
> + - items:
> + - enum:
> + - qcom,pmk7750-gpio
> + - const: qcom,pmk8550-gpio
> + - const: qcom,spmi-gpio
>
> reg:
> maxItems: 1
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260611110708.69234-2-krzysztof.kozlowski@oss.qualcomm.com?part=1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: pinctrl: qcom,pmic-gpio: Add Qualcomm PMK7750
2026-06-11 11:12 ` sashiko-bot
@ 2026-06-11 12:24 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-06-11 12:24 UTC (permalink / raw)
To: sashiko-reviews; +Cc: robh, devicetree, conor+dt
On 11/06/2026 13:12, sashiko-bot@kernel.org wrote:
>>
>> properties:
>> compatible:
>> - items:
>> - - enum:
> [ ... ]
>> + oneOf:
>> + - items:
>> + - enum:
> [ ... ]
>> + - qcom,pmiv0104-gpio
>> + - qcom,pmk8350-gpio
>> + - qcom,pmk7750-gpio
>
> [Severity: Medium]
> Since qcom,pmk7750-gpio is added here to the standalone enum list, won't
> standalone usage bypass the generation-specific constraints (such as the
> gpio-line-names limit) defined in the allOf conditional block for the
> PMK8550 generation?
I should have removed pmk7750 here :(
Oh, I hate these YAML block re-indentations.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-06-11 12:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-11 11:07 [PATCH v2] dt-bindings: pinctrl: qcom,pmic-gpio: Add Qualcomm PMK7750 Krzysztof Kozlowski
2026-06-11 11:12 ` sashiko-bot
2026-06-11 12:24 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.