All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Florian Westphal <fw@strlen.de>
Cc: <netdev@vger.kernel.org>, <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH net-next 2/2] selftests: netfilter: add phony nft_offload test
Date: Thu, 11 Jun 2026 13:34:10 -0700	[thread overview]
Message-ID: <20260611133410.1c0396b1@kernel.org> (raw)
In-Reply-To: <20260610175906.1767-3-fw@strlen.de>

On Wed, 10 Jun 2026 19:58:44 +0200 Florian Westphal wrote:
> ... "phony", because its not testing offloads, it tests the control
> plane code.  Also test error unwind via fault injection framework.
> 
> For a proper test, real hardware would be required given we'd have
> check if 'previously handed off to hardware' offload commands are
> properly removed again on failure or rule flush.
> 
> Signed-off-by: Florian Westphal <fw@strlen.de>

Validation errors in tools/testing/selftests/net/netfilter/config:
Lines 36-37 invalid order, CONFIG_FAIL_FUNCTION=y should be before CONFIG_IP_VS_RR=m

Shellcheck also has some comments FWIW 

      reply	other threads:[~2026-06-11 20:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-10 17:58 [PATCH net-next 0/2] netdevsim: add fake FT/CLS_FLOWER offload Florian Westphal
2026-06-10 17:58 ` [PATCH net-next 1/2] netdevsim: tc: allow to test nf_tables offload control plane code Florian Westphal
2026-06-11 20:39   ` Jakub Kicinski
2026-06-11 23:12     ` Florian Westphal
2026-06-10 17:58 ` [PATCH net-next 2/2] selftests: netfilter: add phony nft_offload test Florian Westphal
2026-06-11 20:34   ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260611133410.1c0396b1@kernel.org \
    --to=kuba@kernel.org \
    --cc=fw@strlen.de \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.