All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] netdevsim: tc: allow to test nf_tables offload control plane code
Date: Fri, 12 Jun 2026 01:12:33 +0200	[thread overview]
Message-ID: <aitA4f_9YaQV-I_l@strlen.de> (raw)
In-Reply-To: <20260611133910.2887266f@kernel.org>

Jakub Kicinski <kuba@kernel.org> wrote:
> On Wed, 10 Jun 2026 19:58:43 +0200 Florian Westphal wrote:
> > @@ -73,7 +86,10 @@ nsim_setup_tc(struct net_device *dev, enum tc_setup_type type, void *type_data)
> >  						  &nsim_block_cb_list,
> >  						  nsim_setup_tc_block_cb,
> >  						  ns, ns, true);
> > +	case TC_SETUP_FT:
> > +		return 0;
> >  	default:
> >  		return -EOPNOTSUPP;
> >  	}
> >  }
> > +ALLOW_ERROR_INJECTION(nsim_setup_tc, ERRNO);
> 
> As you probably seen other netdevsim offloads use explicit debugfs 
> files to "fail operation X". Slightly easier to deal with, and
> netdevsim is a test harness anyway. But entirely up to you.

I'd rather not reimplement the '30% failure rate' and the 'make-it-fail'
logic (allows to have restrict the error injection to selected
processed), so I would prefer to give fuzzers more rope.

I'll fix up the sashiko hints in v2.

  reply	other threads:[~2026-06-11 23:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-10 17:58 [PATCH net-next 0/2] netdevsim: add fake FT/CLS_FLOWER offload Florian Westphal
2026-06-10 17:58 ` [PATCH net-next 1/2] netdevsim: tc: allow to test nf_tables offload control plane code Florian Westphal
2026-06-11 20:39   ` Jakub Kicinski
2026-06-11 23:12     ` Florian Westphal [this message]
2026-06-10 17:58 ` [PATCH net-next 2/2] selftests: netfilter: add phony nft_offload test Florian Westphal
2026-06-11 20:34   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aitA4f_9YaQV-I_l@strlen.de \
    --to=fw@strlen.de \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.