From: linuxtestproject.agent@gmail.com
To: Jinseok Kim <always.starving0@gmail.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] power_management: rewrite runpwtests04.sh in C
Date: Fri, 12 Jun 2026 16:22:10 +0000 [thread overview]
Message-ID: <20260612162211.4004-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260612122045.14962-1-always.starving0@gmail.com>
Hi Jinseok,
On Fri, 12 Jun 2026 21:20:44 +0900, Jinseok Kim wrote:
> power_management: rewrite runpwtests04.sh in C
> diff --git a/testcases/kernel/power_management/pwtests01.c
> b/testcases/kernel/power_management/pwtests01.c
> new file mode 100644
The old shell script runpwtests04.sh is not deleted by this patch.
Since the Makefile installs all shell scripts via
`INSTALL_TARGETS := *.py *.sh`, the orphaned script will still be
installed even though its runtest entry was removed.
Should runpwtests04.sh (and potentially pm_include.sh if no other
script sources it) be deleted in this patch?
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-06-12 16:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-12 12:20 [LTP] [PATCH v4] power_management: rewrite runpwtests04.sh in C Jinseok Kim
2026-06-12 16:22 ` linuxtestproject.agent [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-06-12 17:13 [LTP] [PATCH v5] " Jinseok Kim
2026-06-12 19:09 ` [LTP] " linuxtestproject.agent
2026-05-24 15:42 [LTP] [PATCH v2] " Jinseok Kim
2026-05-24 17:05 ` [LTP] " linuxtestproject.agent
2026-06-09 8:02 ` linuxtestproject.agent
2026-05-16 20:00 [LTP] [PATCH] " Jinseok Kim
2026-05-17 17:13 ` [LTP] " linuxtestproject.agent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260612162211.4004-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=always.starving0@gmail.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.