Re: [LTP] power_management: rewrite runpwtests04.sh in C

[linuxtestproject.agent@gmail.com]

Hi Jinseok,

On Sat, 13 Jun 2026 02:13:46 +0900, Jinseok Kim wrote:
> power_management: rewrite runpwtests04.sh in C

> The new implementation preserves the original test semantics while
> removing shell dependencies.

This claim is inaccurate in at least two ways:

1. The original shell script calls check_arch from pm_include.sh,
which gates the test to x86/x86_64 and reports TCONF on other
architectures. The new C test drops this gate entirely, relying
on runtime sysfs presence instead. That is arguably better
(runtime detection over compile-time assumptions), but it is a
semantic change that should be mentioned.

2. When /sys/devices/system/cpu/cpuidle does not exist, the
original script skips the loop and falls through to PASS. The
new test calls tst_brk(TCONF) in setup. Again an improvement,
but not "preserved semantics".

Consider rewording the commit body to acknowledge these
intentional behavioral changes rather than claiming equivalence.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp