[PATCH] Docs/mm/damon/design: fix a typo in the Address Unit section

[PATCH] Docs/mm/damon/design: fix a typo in the Address Unit section

[Shardul Deshpande]

The "Address Unit" section misspelled the C type that the DAMON core
layer uses for monitoring target address ranges.  Correct it to read
"unsigned long".

Signed-off-by: Shardul Deshpande <iamsharduld@gmail.com>
---
 Documentation/mm/damon/design.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst
index afc7d52bd..899ac9c69 100644
--- a/Documentation/mm/damon/design.rst
+++ b/Documentation/mm/damon/design.rst
@@ -140,7 +140,7 @@ as Idle page tracking does.
 Address Unit
 ------------
 
-DAMON core layer uses ``unsinged long`` type for monitoring target address
+DAMON core layer uses ``unsigned long`` type for monitoring target address
 ranges.  In some cases, the address space for a given operations set could be
 too large to be handled with the type.  ARM (32-bit) with large physical
 address extension is an example.  For such cases, a per-operations set
-- 
2.43.0

Re: [PATCH] Docs/mm/damon/design: fix a typo in the Address Unit section

[Andrew Morton]

On Fri, 12 Jun 2026 21:10:54 +0530 Shardul Deshpande <iamsharduld@gmail.com> wrote:

> The "Address Unit" section misspelled the C type that the DAMON core
> layer uses for monitoring target address ranges.  Correct it to read
> "unsigned long".
> 
> ...
>
> --- a/Documentation/mm/damon/design.rst
> +++ b/Documentation/mm/damon/design.rst
> @@ -140,7 +140,7 @@ as Idle page tracking does.
>  Address Unit
>  ------------
>  
> -DAMON core layer uses ``unsinged long`` type for monitoring target address
> +DAMON core layer uses ``unsigned long`` type for monitoring target address
>  ranges.  In some cases, the address space for a given operations set could be
>  too large to be handled with the type.  ARM (32-bit) with large physical
>  address extension is an example.  For such cases, a per-operations set

Well we don't want our longs to be singed.

`grep -ri singed .' shows quite a few typos.  "assinged" is popular. 
Perhaps you could prepare a patch which fixes them all and adds
"assinged" to scripts/spelling.txt?

[PATCH] treewide: fix transposed "sign" typos and update spelling.txt

[Shardul Deshpande]

Several comments and one documentation file transpose the letters in
"assigned" and "unsigned", spelling them with "sing" instead of "sign".
Correct all of them.

Of these, the misspelling of "assigned" is not yet flagged by
checkpatch, so also add it to scripts/spelling.txt.

The remaining matches of `grep -ri singed` are RISINGEDGE register and
enum names, not typos.

Suggested-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Shardul Deshpande <iamsharduld@gmail.com>
---
 Documentation/mm/damon/design.rst          | 2 +-
 arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 2 +-
 drivers/gpu/drm/drm_color_mgmt.c           | 2 +-
 drivers/scsi/elx/efct/efct_hw.h            | 2 +-
 drivers/scsi/isci/host.c                   | 2 +-
 drivers/scsi/isci/port.c                   | 2 +-
 drivers/scsi/isci/port_config.c            | 2 +-
 kernel/bpf/helpers.c                       | 2 +-
 scripts/spelling.txt                       | 1 +
 9 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst
index afc7d52bd..899ac9c69 100644
--- a/Documentation/mm/damon/design.rst
+++ b/Documentation/mm/damon/design.rst
@@ -140,7 +140,7 @@ as Idle page tracking does.
 Address Unit
 ------------
 
-DAMON core layer uses ``unsinged long`` type for monitoring target address
+DAMON core layer uses ``unsigned long`` type for monitoring target address
 ranges.  In some cases, the address space for a given operations set could be
 too large to be handled with the type.  ARM (32-bit) with large physical
 address extension is an example.  For such cases, a per-operations set
diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
index 469a5d103..9ae9af40f 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
@@ -562,7 +562,7 @@ &sdc1_rclk {
  *
  * This has entries that are defined by Qcard even if they go to the main
  * board. In cases where the pulls may be board dependent we defer those
- * settings to the board device tree. Drive strengths tend to be assinged here
+ * settings to the board device tree. Drive strengths tend to be assigned here
  * but could conceivably be overwridden by board device trees.
  */
 
diff --git a/drivers/gpu/drm/drm_color_mgmt.c b/drivers/gpu/drm/drm_color_mgmt.c
index e7db4e4ea..cb7f51ff8 100644
--- a/drivers/gpu/drm/drm_color_mgmt.c
+++ b/drivers/gpu/drm/drm_color_mgmt.c
@@ -54,7 +54,7 @@
  *	&drm_crtc_state.degamma_lut.
  *
  * “DEGAMMA_LUT_SIZE”:
- *	Unsinged range property to give the size of the lookup table to be set
+ *	Unsigned range property to give the size of the lookup table to be set
  *	on the DEGAMMA_LUT property (the size depends on the underlying
  *	hardware). If drivers support multiple LUT sizes then they should
  *	publish the largest size, and sub-sample smaller sized LUTs (e.g. for
diff --git a/drivers/scsi/elx/efct/efct_hw.h b/drivers/scsi/elx/efct/efct_hw.h
index f3f4aa78d..20aae0402 100644
--- a/drivers/scsi/elx/efct/efct_hw.h
+++ b/drivers/scsi/elx/efct/efct_hw.h
@@ -59,7 +59,7 @@
 #define EFCT_HW_EQ_DEPTH		1024
 
 /*
- * A CQ will be assinged to each WQ
+ * A CQ will be assigned to each WQ
  * (CQ must have 2X entries of the WQ for abort
  * processing), plus a separate one for each RQ PAIR and one for MQ
  */
diff --git a/drivers/scsi/isci/host.c b/drivers/scsi/isci/host.c
index ff199bab5..1592fc552 100644
--- a/drivers/scsi/isci/host.c
+++ b/drivers/scsi/isci/host.c
@@ -2488,7 +2488,7 @@ struct isci_request *sci_request_by_tag(struct isci_host *ihost, u16 io_tag)
  *    free remote node ids
  * @idev: This is the device object which is requesting the a remote node
  *    id
- * @node_id: This is the remote node id that is assinged to the device if one
+ * @node_id: This is the remote node id that is assigned to the device if one
  *    is available
  *
  * enum sci_status SCI_FAILURE_OUT_OF_RESOURCES if there are no available remote
diff --git a/drivers/scsi/isci/port.c b/drivers/scsi/isci/port.c
index 10bd2aac2..0dea0abb9 100644
--- a/drivers/scsi/isci/port.c
+++ b/drivers/scsi/isci/port.c
@@ -464,7 +464,7 @@ static enum sci_status sci_port_set_phy(struct isci_port *iport, struct isci_phy
 {
 	/* Check to see if we can add this phy to a port
 	 * that means that the phy is not part of a port and that the port does
-	 * not already have a phy assinged to the phy index.
+	 * not already have a phy assigned to the phy index.
 	 */
 	if (!iport->phy_table[iphy->phy_index] &&
 	    !phy_get_non_dummy_port(iphy) &&
diff --git a/drivers/scsi/isci/port_config.c b/drivers/scsi/isci/port_config.c
index 3b4820def..d709c9df8 100644
--- a/drivers/scsi/isci/port_config.c
+++ b/drivers/scsi/isci/port_config.c
@@ -259,7 +259,7 @@ sci_mpc_agent_validate_phy_configuration(struct isci_host *ihost,
 		if (!phy_mask)
 			continue;
 		/*
-		 * Make sure that one or more of the phys were not already assinged to
+		 * Make sure that one or more of the phys were not already assigned to
 		 * a different port. */
 		if ((phy_mask & ~assigned_phy_mask) == 0) {
 			return SCI_FAILURE_UNSUPPORTED_PORT_CONFIGURATION;
diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c
index b5314c9fe..6f56ba88f 100644
--- a/kernel/bpf/helpers.c
+++ b/kernel/bpf/helpers.c
@@ -3601,7 +3601,7 @@ __bpf_kfunc int bpf_copy_from_user_task_str(void *dst, u32 dst__sz,
 	return ret + 1;
 }
 
-/* Keep unsinged long in prototype so that kfunc is usable when emitted to
+/* Keep unsigned long in prototype so that kfunc is usable when emitted to
  * vmlinux.h in BPF programs directly, but note that while in BPF prog, the
  * unsigned long always points to 8-byte region on stack, the kernel may only
  * read and write the 4-bytes on 32-bit.
diff --git a/scripts/spelling.txt b/scripts/spelling.txt
index 2f2e81dbd..3372873cd 100644
--- a/scripts/spelling.txt
+++ b/scripts/spelling.txt
@@ -176,6 +176,7 @@ assgined||assigned
 assiged||assigned
 assigment||assignment
 assigments||assignments
+assinged||assigned
 assistent||assistant
 assocaited||associated
 assocated||associated
-- 
2.43.0

Re: [PATCH] treewide: fix transposed "sign" typos and update spelling.txt

[SeongJae Park]

On Fri, 12 Jun 2026 23:46:32 +0530 Shardul Deshpande <iamsharduld@gmail.com> wrote:

> Several comments and one documentation file transpose the letters in
> "assigned" and "unsigned", spelling them with "sing" instead of "sign".
> Correct all of them.
> 
> Of these, the misspelling of "assigned" is not yet flagged by
> checkpatch, so also add it to scripts/spelling.txt.
> 
> The remaining matches of `grep -ri singed` are RISINGEDGE register and
> enum names, not typos.
> 
> Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Shardul Deshpande <iamsharduld@gmail.com>
> ---
>  Documentation/mm/damon/design.rst          | 2 +-
>  arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 2 +-
>  drivers/gpu/drm/drm_color_mgmt.c           | 2 +-
>  drivers/scsi/elx/efct/efct_hw.h            | 2 +-
>  drivers/scsi/isci/host.c                   | 2 +-
>  drivers/scsi/isci/port.c                   | 2 +-
>  drivers/scsi/isci/port_config.c            | 2 +-
>  kernel/bpf/helpers.c                       | 2 +-
>  scripts/spelling.txt                       | 1 +
>  9 files changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst
> index afc7d52bd..899ac9c69 100644
> --- a/Documentation/mm/damon/design.rst
> +++ b/Documentation/mm/damon/design.rst
> @@ -140,7 +140,7 @@ as Idle page tracking does.
>  Address Unit
>  ------------
>  
> -DAMON core layer uses ``unsinged long`` type for monitoring target address
> +DAMON core layer uses ``unsigned long`` type for monitoring target address
>  ranges.  In some cases, the address space for a given operations set could be
>  too large to be handled with the type.  ARM (32-bit) with large physical
>  address extension is an example.  For such cases, a per-operations set

For the above DAMON part,

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

[...]

Re: [PATCH] Docs/mm/damon/design: fix a typo in the Address Unit section

[SeongJae Park]

On Fri, 12 Jun 2026 21:10:54 +0530 Shardul Deshpande <iamsharduld@gmail.com> wrote:

> The "Address Unit" section misspelled the C type that the DAMON core
> layer uses for monitoring target address ranges.  Correct it to read
> "unsigned long".

Thank you!  I found you sent another patch having this change following
Andrew's comment.  So I reviewed there.

[1] https://lore.kernel.org/20260613000715.791-1-sj@kernel.org


Thanks,
SJ

[...]

Re: [PATCH] treewide: fix transposed "sign" typos and update spelling.txt

[Zenghui Yu]

On 6/13/26 8:07 AM, SeongJae Park wrote:
> On Fri, 12 Jun 2026 23:46:32 +0530 Shardul Deshpande <iamsharduld@gmail.com> wrote:
> 
> > Several comments and one documentation file transpose the letters in
> > "assigned" and "unsigned", spelling them with "sing" instead of "sign".
> > Correct all of them.
> >
> > Of these, the misspelling of "assigned" is not yet flagged by
> > checkpatch, so also add it to scripts/spelling.txt.
> >
> > The remaining matches of `grep -ri singed` are RISINGEDGE register and
> > enum names, not typos.
> >
> > Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> > Signed-off-by: Shardul Deshpande <iamsharduld@gmail.com>
> > ---
> >  Documentation/mm/damon/design.rst          | 2 +-
> >  arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 2 +-
> >  drivers/gpu/drm/drm_color_mgmt.c           | 2 +-
> >  drivers/scsi/elx/efct/efct_hw.h            | 2 +-
> >  drivers/scsi/isci/host.c                   | 2 +-
> >  drivers/scsi/isci/port.c                   | 2 +-
> >  drivers/scsi/isci/port_config.c            | 2 +-
> >  kernel/bpf/helpers.c                       | 2 +-
> >  scripts/spelling.txt                       | 1 +
> >  9 files changed, 9 insertions(+), 8 deletions(-)
> >
> > diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst
> > index afc7d52bd..899ac9c69 100644
> > --- a/Documentation/mm/damon/design.rst
> > +++ b/Documentation/mm/damon/design.rst
> > @@ -140,7 +140,7 @@ as Idle page tracking does.
> >  Address Unit
> >  ------------
> >  
> > -DAMON core layer uses ``unsinged long`` type for monitoring target address
> > +DAMON core layer uses ``unsigned long`` type for monitoring target address
> >  ranges.  In some cases, the address space for a given operations set could be
> >  too large to be handled with the type.  ARM (32-bit) with large physical
> >  address extension is an example.  For such cases, a per-operations set
> 
> For the above DAMON part,
> 
> Reviewed-by: SeongJae Park <sj@kernel.org>

This one has already been fixed in mm-new. See
https://lore.kernel.org/20260520012104.93602-3-sj@kernel.org .

Thanks,
Zenghui