From: Jakub Kicinski <kuba@kernel.org>
To: javen <javen_xu@realsil.com.cn>
Cc: <andrew@lunn.ch>, <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<freddy_gu@realsil.com.cn>, <nb@tipi-net.de>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<daniel@makrotopia.org>, <vladimir.oltean@nxp.com>
Subject: Re: [PATCH net-next v5 2/4] net: phy: c45: add genphy_c45_config_master_slave()
Date: Sat, 13 Jun 2026 16:59:51 -0700 [thread overview]
Message-ID: <20260613165951.115d06b8@kernel.org> (raw)
In-Reply-To: <20260611031839.568-3-javen_xu@realsil.com.cn>
On Thu, 11 Jun 2026 11:18:37 +0800 javen wrote:
> + * Returns negative errno code on failure, 0 if Master/Slave didn't change,
> + * or 1 if Master/Slave modes changed.
Returns:
the colon is needed otherwise:
Warning: drivers/net/phy/phy-c45.c:420 No description found for return value of 'genphy_c45_an_setup_master_slave'
There's also an AI review at
https://sashiko.dev/#/patchset/20260611031839.568-3-javen_xu@realsil.com.cn
--
pw-bot: cr
next prev parent reply other threads:[~2026-06-13 23:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 3:18 [PATCH net-next v5 0/4] Add support for RTL8261C_CG javen
2026-06-11 3:18 ` [PATCH net-next v5 1/4] net: phy: c45: add genphy_c45_soft_reset() javen
2026-06-11 3:18 ` [PATCH net-next v5 2/4] net: phy: c45: add genphy_c45_config_master_slave() javen
2026-06-13 23:59 ` Jakub Kicinski [this message]
2026-06-11 3:18 ` [PATCH net-next v5 3/4] net: phy: realtek: add support for RTL8261C_CG javen
2026-06-11 3:18 ` [PATCH net-next v5 4/4] net: phy: realtek: load firmware " javen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260613165951.115d06b8@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=freddy_gu@realsil.com.cn \
--cc=hkallweit1@gmail.com \
--cc=javen_xu@realsil.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.