All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] crypto: s5p-sss - correct CONFIG_CRYPTO_DEV_EXYNOS_RNG macro name in comment
@ 2026-06-13 22:36 Ethan Nelson-Moore
  2026-06-14  0:50 ` Eric Biggers
  0 siblings, 1 reply; 3+ messages in thread
From: Ethan Nelson-Moore @ 2026-06-13 22:36 UTC (permalink / raw)
  To: linux-crypto, linux-samsung-soc
  Cc: Ethan Nelson-Moore, Krzysztof Kozlowski, Vladimir Zapolskiy,
	Herbert Xu, David S. Miller

A comment in drivers/crypto/s5p-sss.c incorrectly refers to
CONFIG_EXYNOS_RNG instead of CONFIG_CRYPTO_DEV_EXYNOS_RNG. Correct it.

Discovered while searching for CONFIG_* symbols referenced in code but
not defined in any Kconfig file.

Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
---
 drivers/crypto/s5p-sss.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
index bdda7b39af85..9bb1b1661174 100644
--- a/drivers/crypto/s5p-sss.c
+++ b/drivers/crypto/s5p-sss.c
@@ -2151,8 +2151,8 @@ static int s5p_aes_probe(struct platform_device *pdev)
 
 	/*
 	 * Note: HASH and PRNG uses the same registers in secss, avoid
-	 * overwrite each other. This will drop HASH when CONFIG_EXYNOS_RNG
-	 * is enabled in config. We need larger size for HASH registers in
+	 * overwrite each other. This will drop HASH when CONFIG_CRYPTO_DEV_EXYNOS_RNG
+	 * is enabled. We need larger size for HASH registers in
 	 * secss, current describe only AES/DES
 	 */
 	if (IS_ENABLED(CONFIG_CRYPTO_DEV_EXYNOS_HASH)) {
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] crypto: s5p-sss - correct CONFIG_CRYPTO_DEV_EXYNOS_RNG macro name in comment
  2026-06-13 22:36 [PATCH] crypto: s5p-sss - correct CONFIG_CRYPTO_DEV_EXYNOS_RNG macro name in comment Ethan Nelson-Moore
@ 2026-06-14  0:50 ` Eric Biggers
  2026-06-14  1:36   ` Ethan Nelson-Moore
  0 siblings, 1 reply; 3+ messages in thread
From: Eric Biggers @ 2026-06-14  0:50 UTC (permalink / raw)
  To: Ethan Nelson-Moore
  Cc: linux-crypto, linux-samsung-soc, Krzysztof Kozlowski,
	Vladimir Zapolskiy, Herbert Xu, David S. Miller

On Sat, Jun 13, 2026 at 03:36:47PM -0700, Ethan Nelson-Moore wrote:
> A comment in drivers/crypto/s5p-sss.c incorrectly refers to
> CONFIG_EXYNOS_RNG instead of CONFIG_CRYPTO_DEV_EXYNOS_RNG. Correct it.
> 
> Discovered while searching for CONFIG_* symbols referenced in code but
> not defined in any Kconfig file.
> 
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
> ---
>  drivers/crypto/s5p-sss.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
> index bdda7b39af85..9bb1b1661174 100644
> --- a/drivers/crypto/s5p-sss.c
> +++ b/drivers/crypto/s5p-sss.c
> @@ -2151,8 +2151,8 @@ static int s5p_aes_probe(struct platform_device *pdev)
>  
>  	/*
>  	 * Note: HASH and PRNG uses the same registers in secss, avoid
> -	 * overwrite each other. This will drop HASH when CONFIG_EXYNOS_RNG
> -	 * is enabled in config. We need larger size for HASH registers in
> +	 * overwrite each other. This will drop HASH when CONFIG_CRYPTO_DEV_EXYNOS_RNG
> +	 * is enabled. We need larger size for HASH registers in
>  	 * secss, current describe only AES/DES
>  	 */
>  	if (IS_ENABLED(CONFIG_CRYPTO_DEV_EXYNOS_HASH)) {

CONFIG_CRYPTO_DEV_EXYNOS_RNG was already removed by
https://lore.kernel.org/linux-crypto/20260531175932.32171-1-ebiggers@kernel.org/

I didn't want to touch this comment which is nonsense anyway.  But if
you're going to try to update it, it should be updated to correctly
explain that the driver is working around broken devicetree bindings.

- Eric

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] crypto: s5p-sss - correct CONFIG_CRYPTO_DEV_EXYNOS_RNG macro name in comment
  2026-06-14  0:50 ` Eric Biggers
@ 2026-06-14  1:36   ` Ethan Nelson-Moore
  0 siblings, 0 replies; 3+ messages in thread
From: Ethan Nelson-Moore @ 2026-06-14  1:36 UTC (permalink / raw)
  To: Eric Biggers
  Cc: linux-crypto, linux-samsung-soc, Krzysztof Kozlowski,
	Vladimir Zapolskiy, Herbert Xu, David S. Miller

Hi, Eric,

On Sat, Jun 13, 2026 at 5:52 PM Eric Biggers <ebiggers@kernel.org> wrote:
> CONFIG_CRYPTO_DEV_EXYNOS_RNG was already removed by
> https://lore.kernel.org/linux-crypto/20260531175932.32171-1-ebiggers@kernel.org/

Thanks for letting me know.

> I didn't want to touch this comment which is nonsense anyway.  But if
> you're going to try to update it, it should be updated to correctly
> explain that the driver is working around broken devicetree bindings.

Yes, that comment definitely needs rewriting - I had no idea that is
what it is referring to.

Ethan

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-06-14  1:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-13 22:36 [PATCH] crypto: s5p-sss - correct CONFIG_CRYPTO_DEV_EXYNOS_RNG macro name in comment Ethan Nelson-Moore
2026-06-14  0:50 ` Eric Biggers
2026-06-14  1:36   ` Ethan Nelson-Moore

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.