[linux-next:master 13470/13763] drivers/hid/hid-nintendo.c:2435 joycon_read_info() warn: '%pM' cannot be followed by 'U'

[linux-next:master 13470/13763] drivers/hid/hid-nintendo.c:2435 joycon_read_info() warn: '%pM' cannot be followed by 'U'

[kernel test robot]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC: Petr Mladek <pmladek@suse.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   c425609d6ac4012c8bbf01ec2e10e801b1923a7b
commit: 7cde5613006c1a1192efe3da3572d35a2fa5fbfe [13470/13763] HID: nintendo: Use %pM format specifier for MAC addresses
:::::: branch date: 29 hours ago
:::::: commit date: 35 hours ago
config: nios2-randconfig-r072-20260613 (https://download.01.org/0day-ci/archive/20260614/202606140707.plCJDajt-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.5.0
smatch: v0.5.0-9185-gbcc58b9c

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202606140707.plCJDajt-lkp@intel.com/

smatch warnings:
drivers/hid/hid-nintendo.c:2435 joycon_read_info() warn: '%pM' cannot be followed by 'U'

vim +2435 drivers/hid/hid-nintendo.c

08ebba5c270350 Daniel J. Ogorchock 2021-09-11  2413  
294a828759d041 Daniel J. Ogorchock 2021-09-11  2414  static int joycon_read_info(struct joycon_ctlr *ctlr)
1425247383c562 Daniel J. Ogorchock 2021-09-11  2415  {
1425247383c562 Daniel J. Ogorchock 2021-09-11  2416  	int ret;
1425247383c562 Daniel J. Ogorchock 2021-09-11  2417  	int i;
1425247383c562 Daniel J. Ogorchock 2021-09-11  2418  	int j;
1425247383c562 Daniel J. Ogorchock 2021-09-11  2419  	struct joycon_subcmd_request req = { 0 };
1425247383c562 Daniel J. Ogorchock 2021-09-11  2420  	struct joycon_input_report *report;
1425247383c562 Daniel J. Ogorchock 2021-09-11  2421  
1425247383c562 Daniel J. Ogorchock 2021-09-11  2422  	req.subcmd_id = JC_SUBCMD_REQ_DEV_INFO;
b73bc6a51f0c00 Vicki Pfau          2025-10-06  2423  	ret = joycon_send_subcmd(ctlr, &req, 0, 2 * HZ);
1425247383c562 Daniel J. Ogorchock 2021-09-11  2424  	if (ret) {
1425247383c562 Daniel J. Ogorchock 2021-09-11  2425  		hid_err(ctlr->hdev, "Failed to get joycon info; ret=%d\n", ret);
1425247383c562 Daniel J. Ogorchock 2021-09-11  2426  		return ret;
1425247383c562 Daniel J. Ogorchock 2021-09-11  2427  	}
1425247383c562 Daniel J. Ogorchock 2021-09-11  2428  
1425247383c562 Daniel J. Ogorchock 2021-09-11  2429  	report = (struct joycon_input_report *)ctlr->input_buf;
1425247383c562 Daniel J. Ogorchock 2021-09-11  2430  
1425247383c562 Daniel J. Ogorchock 2021-09-11  2431  	for (i = 4, j = 0; j < 6; i++, j++)
4ff5b10840a88e Daniel J. Ogorchock 2021-09-11  2432  		ctlr->mac_addr[j] = report->subcmd_reply.data[i];
1425247383c562 Daniel J. Ogorchock 2021-09-11  2433  
7cde5613006c1a Andy Shevchenko     2026-06-03  2434  	ctlr->mac_addr_str = devm_kasprintf(&ctlr->hdev->dev, GFP_KERNEL, "%pMU",
7cde5613006c1a Andy Shevchenko     2026-06-03 @2435  					    ctlr->mac_addr);
1425247383c562 Daniel J. Ogorchock 2021-09-11  2436  	if (!ctlr->mac_addr_str)
1425247383c562 Daniel J. Ogorchock 2021-09-11  2437  		return -ENOMEM;
1425247383c562 Daniel J. Ogorchock 2021-09-11  2438  	hid_info(ctlr->hdev, "controller MAC = %s\n", ctlr->mac_addr_str);
1425247383c562 Daniel J. Ogorchock 2021-09-11  2439  
94f18bb1994591 Ryan McClelland     2023-12-04  2440  	/*
94f18bb1994591 Ryan McClelland     2023-12-04  2441  	 * Retrieve the type so we can distinguish the controller type
94f18bb1994591 Ryan McClelland     2023-12-04  2442  	 * Unfortantly the hdev->product can't always be used due to a ?bug?
94f18bb1994591 Ryan McClelland     2023-12-04  2443  	 * with the NSO Genesis controller. Over USB, it will report the
94f18bb1994591 Ryan McClelland     2023-12-04  2444  	 * PID as 0x201E, but over bluetooth it will report the PID as 0x2017
94f18bb1994591 Ryan McClelland     2023-12-04  2445  	 * which is the same as the NSO SNES controller. This is different from
94f18bb1994591 Ryan McClelland     2023-12-04  2446  	 * the rest of the controllers which will report the same PID over USB
94f18bb1994591 Ryan McClelland     2023-12-04  2447  	 * and bluetooth.
94f18bb1994591 Ryan McClelland     2023-12-04  2448  	 */
4ff5b10840a88e Daniel J. Ogorchock 2021-09-11  2449  	ctlr->ctlr_type = report->subcmd_reply.data[2];
94f18bb1994591 Ryan McClelland     2023-12-04  2450  	hid_dbg(ctlr->hdev, "controller type = 0x%02X\n", ctlr->ctlr_type);
294a828759d041 Daniel J. Ogorchock 2021-09-11  2451  
1425247383c562 Daniel J. Ogorchock 2021-09-11  2452  	return 0;
1425247383c562 Daniel J. Ogorchock 2021-09-11  2453  }
1425247383c562 Daniel J. Ogorchock 2021-09-11  2454  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki