Re: [PATCH v8 10/27] drm/i915/display: Do not take uncore lock in i915_get_vblank_counter

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The inline function `intel_de_read64_2x32_volatile` is now dead code and should be removed.
--

commit f923f01143a0bb2e1cfb7485bff2c091423e5711
Author: Maarten Lankhorst <dev@lankhorst.se>

drm/i915/display: Do not take uncore lock in i915_get_vblank_counter

This commit prevents taking the uncore and DMC locks repeatedly in a
timing-sensitive path with interrupts disabled. It replaces the volatile
read variant with a new forcewake read variant in the vblank counter code.

> diff --git a/drivers/gpu/drm/i915/display/intel_vblank.c b/drivers/gpu/drm/i915/display/intel_vblank.c
> index c0cc0a4c25dbe..5ca22899055d7 100644
> --- a/drivers/gpu/drm/i915/display/intel_vblank.c
> +++ b/drivers/gpu/drm/i915/display/intel_vblank.c
> @@ -109,8 +109,8 @@ u32 i915_get_vblank_counter(struct drm_crtc *crtc)
>  	 * we get a low value that's stable across two reads of the high
>  	 * register.
>  	 */
> -	frame = intel_de_read64_2x32_volatile(display, PIPEFRAMEPIXEL(display, pipe),
> -					      PIPEFRAME(display, pipe));
> +	frame = intel_de_read64_2x32_fw(display, PIPEFRAMEPIXEL(display, pipe),
> +				        PIPEFRAME(display, pipe));

[Severity: Low]
Since this patch updates the only caller of intel_de_read64_2x32_volatile()
in i915_get_vblank_counter() to use the new intel_de_read64_2x32_fw() 
variant instead, does intel_de_read64_2x32_volatile() become dead code?

If so, should it be completely removed from 
drivers/gpu/drm/i915/display/intel_de.h to clean up unused functions?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260615201846.307297-1-dev@lankhorst.se?part=10