All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ethan Nelson-Moore <enelsonmoore@gmail.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
	Ethan Nelson-Moore <enelsonmoore@gmail.com>,
	linux-sh@vger.kernel.org
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Subject: [PATCH v2] sh: mm: Remove checks for nonexistent CONFIG_CPU_SUBTYPE_ST40
Date: Mon, 15 Jun 2026 15:40:48 -0700	[thread overview]
Message-ID: <20260615224049.19649-2-enelsonmoore@gmail.com> (raw)

The CONFIG_CPU_SUBTYPE_ST40 option was removed in commit f96691872439
("sh: Kill off the remaining ST40 cruft."), but a check for it was
added later in commit d02b08f6e8b184ff ("sh: Clean up places that make
29-bit physical assumptions."). Remove this dead code. Also remove the
definition of and references to the MMUCR_SE bit mask, because it is
defined as zero on all CPUs other than ST40.

Discovered while searching for CONFIG_* symbols referenced in code but
not defined in any Kconfig file.

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
---
Changes in v2: Correctly indicate that the check was added after ST40
support was removed (thanks Geert)

 arch/sh/include/cpu-sh4/cpu/mmu_context.h | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/arch/sh/include/cpu-sh4/cpu/mmu_context.h b/arch/sh/include/cpu-sh4/cpu/mmu_context.h
index 421b56d5c595..4a6148e1ea84 100644
--- a/arch/sh/include/cpu-sh4/cpu/mmu_context.h
+++ b/arch/sh/include/cpu-sh4/cpu/mmu_context.h
@@ -43,12 +43,6 @@
 #define MMUCR_URC		0x0000FC00
 #define MMUCR_URC_SHIFT		10
 
-#if defined(CONFIG_32BIT) && defined(CONFIG_CPU_SUBTYPE_ST40)
-#define MMUCR_SE		(1 << 4)
-#else
-#define MMUCR_SE		(0)
-#endif
-
 #ifdef CONFIG_CPU_HAS_PTEAEX
 #define MMUCR_AEX		(1 << 6)
 #else
@@ -69,7 +63,7 @@
 
 #define MMU_NTLB_ENTRIES	64
 #define MMU_CONTROL_INIT	(MMUCR_AT | MMUCR_TI | MMUCR_SQMD | \
-				 MMUCR_ME | MMUCR_SE | MMUCR_AEX)
+				 MMUCR_ME | MMUCR_AEX)
 
 #define TRA	0xff000020
 #define EXPEVT	0xff000024
-- 
2.43.0


                 reply	other threads:[~2026-06-15 22:41 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260615224049.19649-2-enelsonmoore@gmail.com \
    --to=enelsonmoore@gmail.com \
    --cc=dalias@libc.org \
    --cc=geert+renesas@glider.be \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=linux-sh@vger.kernel.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.