* [PATCH 5.10-6.1] fbdev: vt8500lcdfb: Fix dma_free_coherent() cpu_addr parameter
@ 2026-05-28 12:59 Ben Hutchings
2026-05-28 13:03 ` [6.6] fbdev/vt8500lcdfb: Initialize fb_ops with fbdev macros Ben Hutchings
0 siblings, 1 reply; 3+ messages in thread
From: Ben Hutchings @ 2026-05-28 12:59 UTC (permalink / raw)
To: Sasha Levin, Greg Kroah-Hartman; +Cc: Thomas Fourier, Helge Deller, stable
[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]
Before commit 63a11adaceb8 "fbdev/vt8500lcdfb: Initialize fb_ops with
fbdev macros", the virtual address of the screen buffer was stored in
the fb_info::screen_base field and not fb_info::screen_buffer. The
backport of commit 88b3b9924337 ("fbdev: vt8500lcdfb: fix missing
dma_free_coherent()") did not take that into account.
Change the cpu_addr parameter to dma_free_coherent() accordingly.
Fixes: 778f31be5b8c ("fbdev: vt8500lcdfb: fix missing dma_free_coherent()")
Fixes: 9a9bc60ed372 ("fbdev: vt8500lcdfb: fix missing dma_free_coherent()")
Fixes: 778f31be5b8c ("fbdev: vt8500lcdfb: fix missing dma_free_coherent()")
Signed-off-by: Ben Hutchings <benh@debian.org>
---
drivers/video/fbdev/vt8500lcdfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/vt8500lcdfb.c b/drivers/video/fbdev/vt8500lcdfb.c
index ccd316aac467..1608d21a51ae 100644
--- a/drivers/video/fbdev/vt8500lcdfb.c
+++ b/drivers/video/fbdev/vt8500lcdfb.c
@@ -434,7 +434,7 @@ static int vt8500lcd_probe(struct platform_device *pdev)
fbi->palette_cpu, fbi->palette_phys);
failed_free_mem_virt:
dma_free_coherent(&pdev->dev, fbi->fb.fix.smem_len,
- fbi->fb.screen_buffer, fbi->fb.fix.smem_start);
+ fbi->fb.screen_base, fbi->fb.fix.smem_start);
failed_free_io:
iounmap(fbi->regbase);
failed_free_res:
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [6.6] fbdev/vt8500lcdfb: Initialize fb_ops with fbdev macros
2026-05-28 12:59 [PATCH 5.10-6.1] fbdev: vt8500lcdfb: Fix dma_free_coherent() cpu_addr parameter Ben Hutchings
@ 2026-05-28 13:03 ` Ben Hutchings
2026-06-16 4:50 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Ben Hutchings @ 2026-05-28 13:03 UTC (permalink / raw)
To: Sasha Levin, Greg Kroah-Hartman
Cc: Thomas Fourier, Helge Deller, stable, Thomas Zimmermann,
Javier Martinez Canillas
[-- Attachment #1: Type: text/plain, Size: 347 bytes --]
For 6.6, please cherry-pick commit 63a11adaceb8 "fbdev/vt8500lcdfb:
Initialize fb_ops with fbdev macros" as stable dependency of commit
88b3b9924337 "fbdev: vt8500lcdfb: fix missing dma_free_coherent()".
This seems to be applicable without changes.
Ben.
--
Ben Hutchings - Debian developer, member of kernel, installer and LTS
teams
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [6.6] fbdev/vt8500lcdfb: Initialize fb_ops with fbdev macros
2026-05-28 13:03 ` [6.6] fbdev/vt8500lcdfb: Initialize fb_ops with fbdev macros Ben Hutchings
@ 2026-06-16 4:50 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2026-06-16 4:50 UTC (permalink / raw)
To: Ben Hutchings
Cc: Sasha Levin, Thomas Fourier, Helge Deller, stable,
Thomas Zimmermann, Javier Martinez Canillas
On Thu, May 28, 2026 at 03:03:28PM +0200, Ben Hutchings wrote:
> For 6.6, please cherry-pick commit 63a11adaceb8 "fbdev/vt8500lcdfb:
> Initialize fb_ops with fbdev macros" as stable dependency of commit
> 88b3b9924337 "fbdev: vt8500lcdfb: fix missing dma_free_coherent()".
> This seems to be applicable without changes.
Now applied, thanks.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-06-16 4:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-28 12:59 [PATCH 5.10-6.1] fbdev: vt8500lcdfb: Fix dma_free_coherent() cpu_addr parameter Ben Hutchings
2026-05-28 13:03 ` [6.6] fbdev/vt8500lcdfb: Initialize fb_ops with fbdev macros Ben Hutchings
2026-06-16 4:50 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.