From: Jakub Kicinski <kuba@kernel.org>
To: Meghana Malladi <m-malladi@ti.com>
Cc: <elfring@users.sourceforge.net>, <haokexin@gmail.com>,
<vadim.fedorenko@linux.dev>, <devnexen@gmail.com>,
<horms@kernel.org>, <jacob.e.keller@intel.com>, <arnd@arndb.de>,
<basharath@couthit.com>, <afd@ti.com>, <parvathi@couthit.com>,
<vladimir.oltean@nxp.com>, <rogerq@kernel.org>,
<danishanwar@ti.com>, <pabeni@redhat.com>, <edumazet@google.com>,
<davem@davemloft.net>, <andrew+netdev@lunn.ch>,
<linux-arm-kernel@lists.infradead.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <srk@ti.com>, <vigneshr@ti.com>
Subject: Re: [PATCH net-next v7 2/2] net: ti: icssg-prueth: Add ethtool ops for Frame Preemption MAC Merge
Date: Tue, 16 Jun 2026 08:07:24 -0700 [thread overview]
Message-ID: <20260616080724.0d838fd6@kernel.org> (raw)
In-Reply-To: <d0123269-b1e8-4fba-94b0-b94d3d9a5405@ti.com>
On Tue, 16 Jun 2026 18:24:22 +0530 Meghana Malladi wrote:
> >> Could the firmware-register lookup table used by emac_get_stat_by_name()
> >> be separated from the ethtool -S string table, so the new preemption
> >> counters feed get_mm_stats without also showing up under ethtool -S?
> >
> > This -- not sure about the other complaints but this one looks legit.
>
> I agree that this is legit, but right now there is no other place holder
> other than pa stats to put the mac merge firmware counters. I believe
> the effort needs to go in re-structuring the hardware and firmware stats
> implementation to address this issue.
icssg_all_miig_stats has a true / false that looks like it's supposed
to serve the same purpose? Maybe I don't understand what you're trying
to say
next prev parent reply other threads:[~2026-06-16 15:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 5:25 [PATCH net-next v7 0/2] Add Frame Preemption MAC Merge support for ICSSG Meghana Malladi
2026-06-10 5:25 ` [PATCH net-next v7 1/2] net: ti: icssg-prueth: Add Frame Preemption MAC Merge support Meghana Malladi
2026-06-15 23:10 ` Jakub Kicinski
2026-06-10 5:25 ` [PATCH net-next v7 2/2] net: ti: icssg-prueth: Add ethtool ops for Frame Preemption MAC Merge Meghana Malladi
2026-06-15 23:10 ` Jakub Kicinski
2026-06-15 23:39 ` Jakub Kicinski
2026-06-16 12:54 ` Meghana Malladi
2026-06-16 15:07 ` Jakub Kicinski [this message]
2026-06-12 9:01 ` [PATCH net-next v7 0/2] Add Frame Preemption MAC Merge support for ICSSG Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260616080724.0d838fd6@kernel.org \
--to=kuba@kernel.org \
--cc=afd@ti.com \
--cc=andrew+netdev@lunn.ch \
--cc=arnd@arndb.de \
--cc=basharath@couthit.com \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=devnexen@gmail.com \
--cc=edumazet@google.com \
--cc=elfring@users.sourceforge.net \
--cc=haokexin@gmail.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-malladi@ti.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parvathi@couthit.com \
--cc=rogerq@kernel.org \
--cc=srk@ti.com \
--cc=vadim.fedorenko@linux.dev \
--cc=vigneshr@ti.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.