From: Herve Codina <herve.codina@bootlin.com>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: lan966x_pci: depopulate children on populate failure
Date: Tue, 16 Jun 2026 08:28:02 +0200 [thread overview]
Message-ID: <20260616082802.76ecfd70@bootlin.com> (raw)
In-Reply-To: <20260616004304.95117-1-pengpeng@iscas.ac.cn>
Hi Pengpeng,
On Tue, 16 Jun 2026 08:43:04 +0800
Pengpeng Hou <pengpeng@iscas.ac.cn> wrote:
> lan966x_pci_probe() loads the device-tree overlay and then populates
> child devices from it. If of_platform_default_populate() fails after
> creating any children, the error path removes the overlay without first
> depopulating the partially-created children.
>
> Mirror the remove path ordering on the populate failure path by
> depopulating child devices before unloading the overlay.
>
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
> ---
> drivers/misc/lan966x_pci.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Indeed, thanks for the patch.
Reviewed-by: Herve Codina <herve.codina@bootlin.com>
Best regards,
Hervé
next prev parent reply other threads:[~2026-06-16 6:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 0:43 [PATCH] misc: lan966x_pci: depopulate children on populate failure Pengpeng Hou
2026-06-16 6:28 ` Herve Codina [this message]
2026-06-16 9:35 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260616082802.76ecfd70@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pengpeng@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.