From: "Michael S. Tsirkin" <mst@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Thierry Escande <thierry.escande@vates.tech>,
qemu-devel@nongnu.org, Alexey Gerasimenko <x1917x@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <eduardo@habkost.net>,
Anthony PERARD <anthony@xenproject.org>,
xen-devel@lists.xenproject.org,
qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [PATCH 3/4] q35: Fix incorrect values for PCIEXBAR masks
Date: Tue, 16 Jun 2026 13:31:21 -0400 [thread overview]
Message-ID: <20260616133032-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <46238511-ed5d-4f2d-881d-87120e4a408d@tls.msk.ru>
On Tue, Jun 16, 2026 at 07:25:52PM +0300, Michael Tokarev wrote:
> On 13.03.2026 19:47, Thierry Escande wrote:
> > From: Alexey Gerasimenko <x1917x@gmail.com>
> >
> > There are two small issues in PCIEXBAR address mask handling:
> > - wrong bit positions for address mask bits (see PCIEXBAR description
> > in Q35 datasheet)
> > - incorrect usage of 64ADR_MASK
> >
> > Due to this, attempting to write a valid PCIEXBAR address may cause it
> > to shift to another address, causing memory layout corruption where
> > emulated MMIO regions may overlap real (passed through) MMIO ranges. Fix
> > this by providing correct values.
>
> I'm not sure about the implication of this issue, - is it qemu-stable
> material?
>
> Thanks,
>
> /mjt
I think yes generally, but it worries me this has a high risk for
breaking migration if I missed something.
next prev parent reply other threads:[~2026-06-16 17:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 16:46 [PATCH 0/4] Xen: Add Q35 initial support for HVM guests Thierry Escande
2026-03-13 16:47 ` [PATCH 1/4] pc/xen: Xen Q35 support: provide IRQ handling for PCI devices Thierry Escande
2026-05-24 7:27 ` Michael S. Tsirkin
2026-03-13 16:47 ` [PATCH 2/4] q35/xen: Add Xen support for Q35 Thierry Escande
2026-03-13 16:47 ` Thierry Escande
2026-03-13 16:47 ` [PATCH 3/4] q35: Fix incorrect values for PCIEXBAR masks Thierry Escande
2026-05-24 7:43 ` Michael S. Tsirkin
2026-06-16 16:25 ` Michael Tokarev
2026-06-16 17:31 ` Michael S. Tsirkin [this message]
2026-03-13 16:47 ` [PATCH 4/4] xen: Handle PCIe config space size in cpu_ioreq_config() Thierry Escande
2026-03-14 14:16 ` [PATCH 0/4] Xen: Add Q35 initial support for HVM guests Marek Marczykowski-Górecki
2026-03-24 9:28 ` Anthony PERARD
2026-03-24 9:59 ` Daniel P. Berrangé
2026-04-08 7:33 ` Thierry Escande
2026-05-24 7:15 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260616133032-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=anthony@xenproject.org \
--cc=eduardo@habkost.net \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thierry.escande@vates.tech \
--cc=x1917x@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.