* [PATCH] PCI: imx6: fix building against host-common
@ 2026-06-16 16:39 Arnd Bergmann
2026-06-16 16:51 ` Frank Li
2026-06-16 16:56 ` sashiko-bot
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2026-06-16 16:39 UTC (permalink / raw)
To: Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Bjorn Helgaas, Sherry Sun, Richard Zhu
Cc: Arnd Bergmann, Rob Herring, Christian Bruel, Frank Li, linux-pci,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
When CONFIG_PCI_HOST_COMMON is set to =m, the i.MX6 PCIe driver
fails to link. This can happen when only i.MX endpoint mode is
enabled but not host mode, which would indirectly enable the
host-common driver itself.
ld.lld: error: undefined symbol: pci_host_common_parse_ports
>>> referenced by pci-imx6.c
>>> drivers/pci/controller/dwc/pci-imx6.o:(imx_pcie_host_init) in archive vmlinux.a
ld.lld: error: undefined symbol: pci_host_common_delete_ports
>>> referenced by pci-imx6.c
>>> drivers/pci/controller/dwc/pci-imx6.o:(imx_pcie_host_init) in archive vmlinux.a
>>> referenced by pci-imx6.c
>>> drivers/pci/controller/dwc/pci-imx6.o:(imx_pcie_host_init) in archive vmlinux.a
Select the common module from the endpoint support directly.
Fixes: 250eea5c06f5 ("PCI: imx6: Parse 'reset-gpios' in Root Port nodes")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/pci/controller/dwc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
index aa0b784c85b4..7d49027c6736 100644
--- a/drivers/pci/controller/dwc/Kconfig
+++ b/drivers/pci/controller/dwc/Kconfig
@@ -126,6 +126,7 @@ config PCI_IMX6_EP
depends on ARCH_MXC || COMPILE_TEST
depends on PCI_ENDPOINT
select PCIE_DW_EP
+ select PCI_HOST_COMMON
select PCI_IMX6
help
Enables support for the PCIe controller in the i.MX SoCs to
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] PCI: imx6: fix building against host-common
2026-06-16 16:39 [PATCH] PCI: imx6: fix building against host-common Arnd Bergmann
@ 2026-06-16 16:51 ` Frank Li
2026-06-16 16:56 ` sashiko-bot
1 sibling, 0 replies; 3+ messages in thread
From: Frank Li @ 2026-06-16 16:51 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Bjorn Helgaas, Sherry Sun, Richard Zhu,
Arnd Bergmann, Rob Herring, Christian Bruel, Frank Li, linux-pci,
linux-kernel
On Tue, Jun 16, 2026 at 06:39:59PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When CONFIG_PCI_HOST_COMMON is set to =m, the i.MX6 PCIe driver
> fails to link. This can happen when only i.MX endpoint mode is
> enabled but not host mode, which would indirectly enable the
> host-common driver itself.
>
> ld.lld: error: undefined symbol: pci_host_common_parse_ports
> >>> referenced by pci-imx6.c
> >>> drivers/pci/controller/dwc/pci-imx6.o:(imx_pcie_host_init) in archive vmlinux.a
>
> ld.lld: error: undefined symbol: pci_host_common_delete_ports
> >>> referenced by pci-imx6.c
> >>> drivers/pci/controller/dwc/pci-imx6.o:(imx_pcie_host_init) in archive vmlinux.a
> >>> referenced by pci-imx6.c
> >>> drivers/pci/controller/dwc/pci-imx6.o:(imx_pcie_host_init) in archive vmlinux.a
>
> Select the common module from the endpoint support directly.
>
> Fixes: 250eea5c06f5 ("PCI: imx6: Parse 'reset-gpios' in Root Port nodes")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/pci/controller/dwc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index aa0b784c85b4..7d49027c6736 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -126,6 +126,7 @@ config PCI_IMX6_EP
> depends on ARCH_MXC || COMPILE_TEST
> depends on PCI_ENDPOINT
> select PCIE_DW_EP
> + select PCI_HOST_COMMON
> select PCI_IMX6
> help
> Enables support for the PCIe controller in the i.MX SoCs to
> --
> 2.39.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] PCI: imx6: fix building against host-common
2026-06-16 16:39 [PATCH] PCI: imx6: fix building against host-common Arnd Bergmann
2026-06-16 16:51 ` Frank Li
@ 2026-06-16 16:56 ` sashiko-bot
1 sibling, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-06-16 16:56 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: linux-pci
> From: Arnd Bergmann <arnd@arndb.de>
>
> When CONFIG_PCI_HOST_COMMON is set to =m, the i.MX6 PCIe driver
> fails to link. This can happen when only i.MX endpoint mode is
> enabled but not host mode, which would indirectly enable the
> host-common driver itself.
>
> ld.lld: error: undefined symbol: pci_host_common_parse_ports
> >>> referenced by pci-imx6.c
> >>> drivers/pci/controller/dwc/pci-imx6.o:(imx_pcie_host_init) in archive vmlinux.a
>
> ld.lld: error: undefined symbol: pci_host_common_delete_ports
> >>> referenced by pci-imx6.c
> >>> drivers/pci/controller/dwc/pci-imx6.o:(imx_pcie_host_init) in archive vmlinux.a
> >>> referenced by pci-imx6.c
> >>> drivers/pci/controller/dwc/pci-imx6.o:(imx_pcie_host_init) in archive vmlinux.a
>
> Select the common module from the endpoint support directly.
>
> Fixes: 250eea5c06f5 ("PCI: imx6: Parse 'reset-gpios' in Root Port nodes")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260616164049.3656435-1-arnd@kernel.org?part=1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-06-16 16:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-16 16:39 [PATCH] PCI: imx6: fix building against host-common Arnd Bergmann
2026-06-16 16:51 ` Frank Li
2026-06-16 16:56 ` sashiko-bot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.