From: sashiko-bot@kernel.org
To: "George Guo" <dongtai.guo@linux.dev>
Cc: bpf@vger.kernel.org
Subject: Re: [PATCH 4/5] selftests/bpf: Add LoongArch deny list
Date: Thu, 18 Jun 2026 03:52:19 +0000 [thread overview]
Message-ID: <20260618035219.7A8801F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260618033809.98253-5-dongtai.guo@linux.dev>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `arena_spin_lock` test program relies on BPF atomic operations on arena pointers and will fail on LoongArch, but it was omitted from the newly created `DENYLIST.loongarch`.
--
commit 4b438bd9b260c0e4fb1672644286e66f7e59d089
Author: George Guo <guodongtai@kylinos.cn>
selftests/bpf: Add LoongArch deny list
This commit adds a new test denylist for LoongArch in the BPF selftests. It
disables the arena_atomics test because the LoongArch JIT does not currently
support BPF atomic operations on arena pointers, which causes the verifier
to reject the programs.
> diff --git a/tools/testing/selftests/bpf/DENYLIST.loongarch b/tools/testing/selftests/bpf/DENYLIST.loongarch
> new file mode 100644
> index 0000000000000..925005e4298fa
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/DENYLIST.loongarch
> @@ -0,0 +1,2 @@
> +# loongarch64 deny list for BPF CI and local vmtest
> +arena_atomics # JIT does not support atomics in arena (verifier rejects BPF_ATOMIC on arena pointers)
[Severity: Medium]
Should the arena_spin_lock test be added to this list as well?
The arena_spin_lock test also relies on BPF atomic operations on arena
pointers through atomic_try_cmpxchg_acquire(). Since the verifier rejects
BPF_ATOMIC on arena pointers for LoongArch, will arena_spin_lock also fail
to load and cause CI runs to break?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260618033809.98253-1-dongtai.guo@linux.dev?part=4
next prev parent reply other threads:[~2026-06-18 3:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 3:38 [PATCH 0/5] LoongArch: BPF: arena instruction gating, private stack and exceptions George Guo
2026-06-18 3:38 ` [PATCH 1/5] LoongArch: BPF: Gate unsupported arena instructions via bpf_jit_supports_insn() George Guo
2026-06-18 3:53 ` sashiko-bot
2026-06-18 4:19 ` bot+bpf-ci
2026-06-18 3:38 ` [PATCH 2/5] LoongArch: BPF: Add private stack support George Guo
2026-06-18 3:55 ` sashiko-bot
2026-06-18 3:38 ` [PATCH 3/5] LoongArch: BPF: Add exceptions (bpf_throw) support George Guo
2026-06-18 3:55 ` sashiko-bot
2026-06-18 3:38 ` [PATCH 4/5] selftests/bpf: Add LoongArch deny list George Guo
2026-06-18 3:52 ` sashiko-bot [this message]
2026-06-18 3:38 ` [PATCH 5/5] selftests/bpf: Enable struct_ops private stack test for LoongArch George Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260618035219.7A8801F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=dongtai.guo@linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.