From: Heiko Carstens <hca@linux.ibm.com>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Alexander Gordeev <agordeev@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH -next] s390/idle: Add missing EXPORT_SYMBOL()
Date: Thu, 18 Jun 2026 06:53:20 +0200 [thread overview]
Message-ID: <20260618045320.11310A46-hca@linux.ibm.com> (raw)
In-Reply-To: <ajLJhMC9SDjeSQtR@monoceros>
On Wed, Jun 17, 2026 at 06:25:07PM +0200, Uwe Kleine-König wrote:
> On Wed, Jun 17, 2026 at 04:53:13PM +0200, Heiko Carstens wrote:
> > Uwe Kleine-König reported this build breakage caused by a recent commit
> > which provides arch specific kcpustat_field_idle()/kcpustat_field_iowait()
> > functions:
> >
> > ERROR: modpost: "arch_kcpustat_field_idle" [drivers/leds/trigger/ledtrig-activity.ko] undefined!
> > ERROR: modpost: "arch_kcpustat_field_iowait" [drivers/leds/trigger/ledtrig-activity.ko] undefined!
> >
> > Fix this by adding the missing EXPORT_SYMBOL().
>
> Did you consider EXPORT_SYMBOL_GPL() which AFAIK is prefered over the
> non-GPL one?
My mistake. I really shouldn't write patches in a hurry a few minutes
before I shutdown my system (what could go wrong?).
Sashiko reported the same. Will also be fixed.
> Tested-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Thanks a lot!
prev parent reply other threads:[~2026-06-18 4:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-17 14:53 [PATCH -next] s390/idle: Add missing EXPORT_SYMBOL() Heiko Carstens
2026-06-17 15:00 ` sashiko-bot
2026-06-17 16:25 ` Uwe Kleine-König
2026-06-18 4:53 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260618045320.11310A46-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.