All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] PCI: imx6: fix building against pwrctrl
@ 2026-06-18 14:36 Arnd Bergmann
  0 siblings, 0 replies; only message in thread
From: Arnd Bergmann @ 2026-06-18 14:36 UTC (permalink / raw)
  To: Lorenzo Pieralisi, Krzysztof Wilczyński,
	Manivannan Sadhasivam, Bjorn Helgaas
  Cc: Arnd Bergmann, Rob Herring, Frank Li, linux-pci, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

When endpoint mode is built-in, but pwrctrl support is in a loadable
module, the imx driver fails to build because the unused host
support still tries to link against pwrctrl:

ld.lld: error: undefined symbol: pci_pwrctrl_power_off_devices
>>> referenced by pci-imx6.c:1988 (drivers/pci/controller/dwc/pci-imx6.c:1988)
>>>               drivers/pci/controller/dwc/pci-imx6.o:(imx_pcie_shutdown) in archive vmlinux.a

Add one more select for this.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
----
There is already another fix pending that I sent earlier, see
https://lore.kernel.org/all/ajF_LyjOnINAHvA3@lizhi-Precision-Tower-5810/

If you prefer a combined patch, I can send an updated version,
or you can just fold the two into one commit when applying.
---
 drivers/pci/controller/dwc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
index 7d49027c6736..49a7a2c50ca1 100644
--- a/drivers/pci/controller/dwc/Kconfig
+++ b/drivers/pci/controller/dwc/Kconfig
@@ -128,6 +128,7 @@ config PCI_IMX6_EP
 	select PCIE_DW_EP
 	select PCI_HOST_COMMON
 	select PCI_IMX6
+	select PCI_PWRCTRL_GENERIC
 	help
 	  Enables support for the PCIe controller in the i.MX SoCs to
 	  work in endpoint mode. The PCI controller on i.MX is based
-- 
2.39.5


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-06-18 14:36 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-18 14:36 [PATCH] PCI: imx6: fix building against pwrctrl Arnd Bergmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.