All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/3] gpio: tb10x: W=1 warning fix and style cleanups
@ 2026-06-18 15:56 Igor Putko
  2026-06-18 15:56 ` [PATCH 1/3] gpio: tb10x: fix struct tb10x_gpio kernel-doc Igor Putko
  0 siblings, 1 reply; 4+ messages in thread
From: Igor Putko @ 2026-06-18 15:56 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski; +Cc: linux-gpio, linux-kernel, Igor Putko

This series fixes a kernel-doc warning in the tb10x GPIO driver
and addresses two minor checkpatch.pl coding style issues.

Patch 1 fixes the kernel-doc structure formatting.
Patch 2 replaces bare unsigned with unsigned int.
Patch 3 removes unnecessary braces from a single-statement block.

Igor Putko (3):
  gpio: tb10x: fix struct tb10x_gpio kernel-doc
  gpio: tb10x: use unsigned int instead of bare unsigned
  gpio: tb10x: remove unnecessary braces

 drivers/gpio/gpio-tb10x.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/3] gpio: tb10x: fix struct tb10x_gpio kernel-doc
  2026-06-18 15:56 [PATCH 0/3] gpio: tb10x: W=1 warning fix and style cleanups Igor Putko
@ 2026-06-18 15:56 ` Igor Putko
  2026-06-18 15:56   ` [PATCH 2/3] gpio: tb10x: use unsigned int instead of bare unsigned Igor Putko
  0 siblings, 1 reply; 4+ messages in thread
From: Igor Putko @ 2026-06-18 15:56 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski; +Cc: linux-gpio, linux-kernel, Igor Putko

Fix build warning by adding the missing structure name and
description to the kernel-doc comment block.

Signed-off-by: Igor Putko <igorpetindev@gmail.com>
---
 drivers/gpio/gpio-tb10x.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-tb10x.c b/drivers/gpio/gpio-tb10x.c
index 3c8fd322a713..705bfd80a8d0 100644
--- a/drivers/gpio/gpio-tb10x.c
+++ b/drivers/gpio/gpio-tb10x.c
@@ -33,6 +33,7 @@
 
 
 /**
+ * struct tb10x_gpio - TB10x GPIO controller structure
  * @base: register base address
  * @domain: IRQ domain of GPIO generated interrupts managed by this controller
  * @irq: Interrupt line of parent interrupt controller
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/3] gpio: tb10x: use unsigned int instead of bare unsigned
  2026-06-18 15:56 ` [PATCH 1/3] gpio: tb10x: fix struct tb10x_gpio kernel-doc Igor Putko
@ 2026-06-18 15:56   ` Igor Putko
  2026-06-18 15:56     ` [PATCH 3/3] gpio: tb10x: remove unnecessary braces Igor Putko
  0 siblings, 1 reply; 4+ messages in thread
From: Igor Putko @ 2026-06-18 15:56 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski; +Cc: linux-gpio, linux-kernel, Igor Putko

Fix the checkpatch.pl warning by using 'unsigned int' instead of
the bare use of 'unsigned' for the offset parameter in
tb10x_gpio_to_irq().

Signed-off-by: Igor Putko <igorpetindev@gmail.com>
---
 drivers/gpio/gpio-tb10x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-tb10x.c b/drivers/gpio/gpio-tb10x.c
index 705bfd80a8d0..d30524dbc841 100644
--- a/drivers/gpio/gpio-tb10x.c
+++ b/drivers/gpio/gpio-tb10x.c
@@ -51,7 +51,7 @@ static inline u32 tb10x_reg_read(struct tb10x_gpio *gpio, unsigned int offs)
 	return ioread32(gpio->base + offs);
 }
 
-static int tb10x_gpio_to_irq(struct gpio_chip *chip, unsigned offset)
+static int tb10x_gpio_to_irq(struct gpio_chip *chip, unsigned int offset)
 {
 	struct tb10x_gpio *tb10x_gpio = gpiochip_get_data(chip);
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 3/3] gpio: tb10x: remove unnecessary braces
  2026-06-18 15:56   ` [PATCH 2/3] gpio: tb10x: use unsigned int instead of bare unsigned Igor Putko
@ 2026-06-18 15:56     ` Igor Putko
  0 siblings, 0 replies; 4+ messages in thread
From: Igor Putko @ 2026-06-18 15:56 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski; +Cc: linux-gpio, linux-kernel, Igor Putko

Fix the checkpatch.pl warning by removing unnecessary braces from
a single-statement if-block in tb10x_gpio_probe().

Signed-off-by: Igor Putko <igorpetindev@gmail.com>
---
 drivers/gpio/gpio-tb10x.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-tb10x.c b/drivers/gpio/gpio-tb10x.c
index d30524dbc841..7fb8e6223bd1 100644
--- a/drivers/gpio/gpio-tb10x.c
+++ b/drivers/gpio/gpio-tb10x.c
@@ -167,9 +167,8 @@ static int tb10x_gpio_probe(struct platform_device *pdev)
 		tb10x_gpio->domain = irq_domain_create_linear(dev_fwnode(dev),
 							      tb10x_gpio->chip.gc.ngpio,
 							      &irq_generic_chip_ops, NULL);
-		if (!tb10x_gpio->domain) {
+		if (!tb10x_gpio->domain)
 			return -ENOMEM;
-		}
 
 		ret = irq_alloc_domain_generic_chips(tb10x_gpio->domain,
 				tb10x_gpio->chip.gc.ngpio, 1, tb10x_gpio->chip.gc.label,
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-06-18 15:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-18 15:56 [PATCH 0/3] gpio: tb10x: W=1 warning fix and style cleanups Igor Putko
2026-06-18 15:56 ` [PATCH 1/3] gpio: tb10x: fix struct tb10x_gpio kernel-doc Igor Putko
2026-06-18 15:56   ` [PATCH 2/3] gpio: tb10x: use unsigned int instead of bare unsigned Igor Putko
2026-06-18 15:56     ` [PATCH 3/3] gpio: tb10x: remove unnecessary braces Igor Putko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.