From: "Michael Büsch" <m@bues.ch>
To: Alessio Ferri <alessio.ferri@mythread.it>
Cc: Alessio Ferri <alessio.ferri.3012@gmail.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
b43-dev@lists.infradead.org
Subject: Re: [PATCH 1/4] bcma: host_pci: add BCM4352 device ID 0x43b3
Date: Thu, 18 Jun 2026 19:57:14 +0200 [thread overview]
Message-ID: <20260618195714.5620e0ec@barney> (raw)
In-Reply-To: <20260617-b43-add-4352-wip-v1-1-c81323496720@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1356 bytes --]
On Wed, 17 Jun 2026 23:42:08 +0200
Alessio Ferri <alessio.ferri@mythread.it> wrote:
> From: Alessio Ferri <alessio.ferri.3012@gmail.com>
>
> The BCM4352 is an AC PHY. It is missing from bcma_pci_bridge_tbl[],
> so bcma-pci-bridge does not bind. Add the ID.
>
> The chip identifies as BCM4352 (chip rev 3, PHY type AC); b43 with AC-PHY
> support handles it once bcma reaches the D11 core.
>
> Signed-off-by: Alessio Ferri <alessio.ferri@mythread.it>
> ---
> drivers/bcma/host_pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bcma/host_pci.c b/drivers/bcma/host_pci.c
> index 3dc2985063f1..f6cf722a3798 100644
> --- a/drivers/bcma/host_pci.c
> +++ b/drivers/bcma/host_pci.c
> @@ -298,6 +298,7 @@ static const struct pci_device_id bcma_pci_bridge_tbl[] = {
> { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, 0x43a9) },
> { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, 0x43aa) },
> { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, 0x43b1) },
> + { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, 0x43b3) },
> { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, 0x4727) },
> { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, 43227) }, /* 0xa8db, BCM43217 (sic!) */
> { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, 43228) }, /* 0xa8dc */
>
Please submit this patch last, after the driver is expected to actually work
on the device.
--
Michael Büsch
https://bues.ch/
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 149 bytes --]
_______________________________________________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
WARNING: multiple messages have this Message-ID (diff)
From: "Michael Büsch" <m@bues.ch>
To: Alessio Ferri <alessio.ferri@mythread.it>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
b43-dev@lists.infradead.org,
"Alessio Ferri" <alessio.ferri.3012@gmail.com>
Subject: Re: [PATCH 1/4] bcma: host_pci: add BCM4352 device ID 0x43b3
Date: Thu, 18 Jun 2026 19:57:14 +0200 [thread overview]
Message-ID: <20260618195714.5620e0ec@barney> (raw)
In-Reply-To: <20260617-b43-add-4352-wip-v1-1-c81323496720@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1356 bytes --]
On Wed, 17 Jun 2026 23:42:08 +0200
Alessio Ferri <alessio.ferri@mythread.it> wrote:
> From: Alessio Ferri <alessio.ferri.3012@gmail.com>
>
> The BCM4352 is an AC PHY. It is missing from bcma_pci_bridge_tbl[],
> so bcma-pci-bridge does not bind. Add the ID.
>
> The chip identifies as BCM4352 (chip rev 3, PHY type AC); b43 with AC-PHY
> support handles it once bcma reaches the D11 core.
>
> Signed-off-by: Alessio Ferri <alessio.ferri@mythread.it>
> ---
> drivers/bcma/host_pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bcma/host_pci.c b/drivers/bcma/host_pci.c
> index 3dc2985063f1..f6cf722a3798 100644
> --- a/drivers/bcma/host_pci.c
> +++ b/drivers/bcma/host_pci.c
> @@ -298,6 +298,7 @@ static const struct pci_device_id bcma_pci_bridge_tbl[] = {
> { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, 0x43a9) },
> { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, 0x43aa) },
> { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, 0x43b1) },
> + { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, 0x43b3) },
> { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, 0x4727) },
> { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, 43227) }, /* 0xa8db, BCM43217 (sic!) */
> { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, 43228) }, /* 0xa8dc */
>
Please submit this patch last, after the driver is expected to actually work
on the device.
--
Michael Büsch
https://bues.ch/
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-06-18 17:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-17 21:42 [PATCH 0/4] bcma/ssb/b43: BCM4352 AC-PHY wip Alessio Ferri
2026-06-17 21:42 ` Alessio Ferri
2026-06-17 21:42 ` [PATCH 1/4] bcma: host_pci: add BCM4352 device ID 0x43b3 Alessio Ferri
2026-06-17 21:42 ` Alessio Ferri
2026-06-18 17:57 ` Michael Büsch [this message]
2026-06-18 17:57 ` Michael Büsch
2026-06-17 21:42 ` [PATCH 2/4] bcma: pmu: program max resource mask on BCM4352/BCM4360 Alessio Ferri
2026-06-17 21:42 ` Alessio Ferri
2026-06-17 21:42 ` [PATCH 3/4] ssb: bcma: add SPROM revision 11 extraction Alessio Ferri
2026-06-17 21:42 ` Alessio Ferri
2026-06-17 21:42 ` [PATCH 4/4] b43: align DMA64 descriptor ring to 64K on AC cores Alessio Ferri
2026-06-17 21:42 ` Alessio Ferri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260618195714.5620e0ec@barney \
--to=m@bues.ch \
--cc=alessio.ferri.3012@gmail.com \
--cc=alessio.ferri@mythread.it \
--cc=b43-dev@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.