All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Rishi Chhibber <rishi.chhibber@broadcom.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
	ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com,
	vamsi-krishna.brahmajosyula@broadcom.com, yin.ding@broadcom.com,
	tapas.kundu@broadcom.com
Subject: Re: [PATCH] misc: vmw_zerocopy: Add VMware zero-copy buffer sharing driver
Date: Sat, 20 Jun 2026 07:06:10 +0200	[thread overview]
Message-ID: <2026062008-green-slashing-b3c7@gregkh> (raw)
In-Reply-To: <2026062044-crib-commodore-bea7@gregkh>

On Sat, Jun 20, 2026 at 07:04:55AM +0200, Greg KH wrote:
> On Fri, Jun 19, 2026 at 11:27:10AM -0700, Rishi Chhibber wrote:
> > This driver implements a misc character device (/dev/vmw_zc) that allows
> > guest userspace applications to share pinned memory buffers with a
> > VMware hypervisor-side peer using the VMCI datagram interface.
> > 
> > The driver pins user pages via get_user_pages_fast(), transmits their
> > physical page frame numbers to the hypervisor peer over VMCI, and avoids
> > an intermediate copy between the guest workload VM and the hypervisor.
> > 
> > The hypervisor-side peer for this interface only speaks VMCI; there is no
> > virtio backend implemented on the VMware host for it. The closest
> > existing upstream transport, vsock (virtio-vsock), provides a socket
> > bytestream/datagram abstraction and does not expose a way to hand a set
> > of pinned guest page frame numbers to the host for true zero-copy
> > access; it would still require copying the payload through the socket.
> > This driver's purpose is specifically to pin guest pages and pass their
> > PFNs to the host so the payload is never copied. It also supports
> > bundling multiple buffers in a single request, which is required for the
> > all-or-none semantics of page-level zero-copy transfers.
> > 
> > Signed-off-by: Rishi Chhibber <rishi.chhibber@broadcom.com>
> > ---
> > Changes in v3:
> 
> There is no "v3" in the subject line :(

And, because of this, I will strongly recommend and almost require now,
for you to get another internal person that has experience doing kernel
development, to review and sign off on the next version of your patch.

The community shouldn't be forced to do basic review like this, that's
what your coworkers are for.

thanks,

greg k-h

  reply	other threads:[~2026-06-20  5:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-17 20:31 [PATCH] misc: vmw_zerocopy: Add VMware zero-copy buffer sharing driver Rishi Chhibber
2026-06-18 10:26 ` Greg KH
2026-06-18 18:10 ` [PATCH v2] " Rishi Chhibber
2026-06-19  5:08   ` Greg KH
2026-06-19  5:10   ` Greg KH
2026-06-19 15:12     ` David Laight
2026-06-19 18:27 ` [PATCH] " Rishi Chhibber
2026-06-20  5:04   ` Greg KH
2026-06-20  5:06     ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-06-17 20:27 Rishi Chhibber
2026-06-17 20:45 ` Rishi Chhibber
2026-06-17 20:26 Rishi Chhibber
2026-06-17 20:45 ` Rishi Chhibber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026062008-green-slashing-b3c7@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=ajay.kaher@broadcom.com \
    --cc=alexey.makhalov@broadcom.com \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rishi.chhibber@broadcom.com \
    --cc=tapas.kundu@broadcom.com \
    --cc=vamsi-krishna.brahmajosyula@broadcom.com \
    --cc=yin.ding@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.