[kvm-unit-tests PATCH] checkpatch: add support for Assisted-by tag

[kvm-unit-tests PATCH] checkpatch: add support for Assisted-by tag

[Andrew Jones]

Import Linux commit d1db4118489f ("checkpatch: add support for
Assisted-by tag").

(I should have used AI for this, since it'd be fun to include that
tag on this tag-enabling patch, but sometimes I still do my own
homework!)

Signed-off-by: Andrew Jones <andrew.jones@linux.dev>
---
 scripts/checkpatch.pl | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index e858261c95a8..653bec1f6ea5 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -626,6 +626,7 @@ our $signature_tags = qr{(?xi:
 	Reviewed-by:|
 	Reported-by:|
 	Suggested-by:|
+	Assisted-by:|
 	To:|
 	Cc:
 )};
@@ -3073,6 +3074,15 @@ sub process {
 				}
 			}
 
+			# Assisted-by uses AGENT_NAME:MODEL_VERSION format, not email
+			if ($sign_off =~ /^Assisted-by:/i) {
+				if ($email !~ /^\S+:\S+/) {
+					WARN("BAD_SIGN_OFF",
+					     "Assisted-by expects 'AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]' format\n" . $herecurr);
+				}
+				next;
+			}
+
 			my ($email_name, $name_comment, $email_address, $comment) = parse_email($email);
 			my $suggested_email = format_email(($email_name, $name_comment, $email_address, $comment));
 			if ($suggested_email eq "") {
-- 
2.43.0

Re: [kvm-unit-tests PATCH] checkpatch: add support for Assisted-by tag

[Paolo Bonzini]

On Mon, Jun 22, 2026 at 6:41 PM Andrew Jones <andrew.jones@linux.dev> wrote:
>
> Import Linux commit d1db4118489f ("checkpatch: add support for
> Assisted-by tag").
>
> (I should have used AI for this, since it'd be fun to include that
> tag on this tag-enabling patch, but sometimes I still do my own
> homework!)

Personally, I don't see the point in providing free advertising to AI
companies, so if I had to choose I would do "WARN(...) if ($sign_off
=~ /^Assisted-by:/i)". It's more important to know what AI was used
*for*, than what AI was used period.

But I won't complain if people want this patch.

Paolo

>
> Signed-off-by: Andrew Jones <andrew.jones@linux.dev>
> ---
>  scripts/checkpatch.pl | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index e858261c95a8..653bec1f6ea5 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -626,6 +626,7 @@ our $signature_tags = qr{(?xi:
>         Reviewed-by:|
>         Reported-by:|
>         Suggested-by:|
> +       Assisted-by:|
>         To:|
>         Cc:
>  )};
> @@ -3073,6 +3074,15 @@ sub process {
>                                 }
>                         }
>
> +                       # Assisted-by uses AGENT_NAME:MODEL_VERSION format, not email
> +                       if ($sign_off =~ /^Assisted-by:/i) {
> +                               if ($email !~ /^\S+:\S+/) {
> +                                       WARN("BAD_SIGN_OFF",
> +                                            "Assisted-by expects 'AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]' format\n" . $herecurr);
> +                               }
> +                               next;
> +                       }
> +
>                         my ($email_name, $name_comment, $email_address, $comment) = parse_email($email);
>                         my $suggested_email = format_email(($email_name, $name_comment, $email_address, $comment));
>                         if ($suggested_email eq "") {
> --
> 2.43.0
>

Re: [kvm-unit-tests PATCH] checkpatch: add support for Assisted-by tag

[Andrew Jones]

On Mon, Jun 22, 2026 at 06:43:45PM +0200, Paolo Bonzini wrote:
> On Mon, Jun 22, 2026 at 6:41 PM Andrew Jones <andrew.jones@linux.dev> wrote:
> >
> > Import Linux commit d1db4118489f ("checkpatch: add support for
> > Assisted-by tag").
> >
> > (I should have used AI for this, since it'd be fun to include that
> > tag on this tag-enabling patch, but sometimes I still do my own
> > homework!)
> 
> Personally, I don't see the point in providing free advertising to AI
> companies, so if I had to choose I would do "WARN(...) if ($sign_off
> =~ /^Assisted-by:/i)". It's more important to know what AI was used
> *for*, than what AI was used period.
> 
> But I won't complain if people want this patch.

The process is now well established over in Linux kernel land and we
encourage kvm-unit-tests contributors to follow Linux processes. The
motivation for this patch is because I just queued an ARM patch which
used the Linux process and it failed checkpatch. I'd rather checkpatch
succeed than to have to tell people to remove/modify the tags they're
used to using with the kernel.

We can encourage contributors to also add sentences stating how AI
assisted when an AI assistance tag is provided in order to capture
the "AI used for what" part.

Thanks,
drew