From: Bjorn Helgaas <helgaas@kernel.org>
To: Hans Zhang <18255117159@163.com>
Cc: bhelgaas@google.com, Manivannan Sadhasivam <mani@kernel.org>,
lpieralisi@kernel.org, kwilczynski@kernel.org, heiko@sntech.de,
yue.wang@amlogic.com, pali@kernel.org, neil.armstrong@linaro.org,
robh@kernel.org, jingoohan1@gmail.com, khilman@baylibre.com,
jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
cassel@kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v7 0/2] PCI: Configure Root Port MPS during host probing
Date: Mon, 22 Jun 2026 12:14:48 -0500 [thread overview]
Message-ID: <20260622171448.GA678675@bhelgaas> (raw)
In-Reply-To: <dae17d36-c7d2-467b-a621-3c55e08a67a8@163.com>
On Fri, Jun 19, 2026 at 11:29:39PM +0800, Hans Zhang wrote:
> On 5/6/26 22:00, Manivannan Sadhasivam wrote:
> > On Fri, Nov 28, 2025 at 01:09:06AM +0800, Hans Zhang wrote:
> > > Current PCIe initialization exhibits a key optimization gap: Root Ports
> > > may operate with non-optimal Maximum Payload Size (MPS) settings. While
> > > downstream device configuration is handled during bus enumeration, Root
> > > Port MPS values inherited from firmware or hardware defaults often fail
> > > to utilize the full capabilities supported by controller hardware. This
> > > results in suboptimal data transfer efficiency throughout the PCIe
> > > hierarchy.
> > >
> > > This patch series addresses this by:
> > >
> > > 1. Core PCI enhancement (Patch 1):
> > > - Proactively configures Root Port MPS during host controller probing
> > > - Sets initial MPS to hardware maximum (128 << dev->pcie_mpss)
> > > - Conditional on PCIe bus tuning being enabled (PCIE_BUS_TUNE_OFF unset)
> > > and not in PCIE_BUS_PEER2PEER mode (which requires default 128 bytes)
> > > - Maintains backward compatibility via PCIE_BUS_TUNE_OFF check
> > > - Preserves standard MPS negotiation during downstream enumeration
> > >
> > > 2. Driver cleanup (Patch 2):
> > > - Removes redundant MPS configuration from Meson PCIe controller driver
> > > - Functionality is now centralized in PCI core
> > > - Simplifies driver maintenance long-term
> > >
> >
> > For the series,
> >
> > Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
> >
> > Bjorn: Could you please take a look? This series has been floating for a
> > while...
>
> Hello Bjorn,
>
> Any chance for this series to be applied?
It's too late for v7.2; we're already more than halfway through the
merge window. We can look again for v7.3 after v7.2-rc1.
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Hans Zhang <18255117159@163.com>
Cc: bhelgaas@google.com, Manivannan Sadhasivam <mani@kernel.org>,
lpieralisi@kernel.org, kwilczynski@kernel.org, heiko@sntech.de,
yue.wang@amlogic.com, pali@kernel.org, neil.armstrong@linaro.org,
robh@kernel.org, jingoohan1@gmail.com, khilman@baylibre.com,
jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
cassel@kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v7 0/2] PCI: Configure Root Port MPS during host probing
Date: Mon, 22 Jun 2026 12:14:48 -0500 [thread overview]
Message-ID: <20260622171448.GA678675@bhelgaas> (raw)
In-Reply-To: <dae17d36-c7d2-467b-a621-3c55e08a67a8@163.com>
On Fri, Jun 19, 2026 at 11:29:39PM +0800, Hans Zhang wrote:
> On 5/6/26 22:00, Manivannan Sadhasivam wrote:
> > On Fri, Nov 28, 2025 at 01:09:06AM +0800, Hans Zhang wrote:
> > > Current PCIe initialization exhibits a key optimization gap: Root Ports
> > > may operate with non-optimal Maximum Payload Size (MPS) settings. While
> > > downstream device configuration is handled during bus enumeration, Root
> > > Port MPS values inherited from firmware or hardware defaults often fail
> > > to utilize the full capabilities supported by controller hardware. This
> > > results in suboptimal data transfer efficiency throughout the PCIe
> > > hierarchy.
> > >
> > > This patch series addresses this by:
> > >
> > > 1. Core PCI enhancement (Patch 1):
> > > - Proactively configures Root Port MPS during host controller probing
> > > - Sets initial MPS to hardware maximum (128 << dev->pcie_mpss)
> > > - Conditional on PCIe bus tuning being enabled (PCIE_BUS_TUNE_OFF unset)
> > > and not in PCIE_BUS_PEER2PEER mode (which requires default 128 bytes)
> > > - Maintains backward compatibility via PCIE_BUS_TUNE_OFF check
> > > - Preserves standard MPS negotiation during downstream enumeration
> > >
> > > 2. Driver cleanup (Patch 2):
> > > - Removes redundant MPS configuration from Meson PCIe controller driver
> > > - Functionality is now centralized in PCI core
> > > - Simplifies driver maintenance long-term
> > >
> >
> > For the series,
> >
> > Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
> >
> > Bjorn: Could you please take a look? This series has been floating for a
> > while...
>
> Hello Bjorn,
>
> Any chance for this series to be applied?
It's too late for v7.2; we're already more than halfway through the
merge window. We can look again for v7.3 after v7.2-rc1.
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Hans Zhang <18255117159@163.com>
Cc: bhelgaas@google.com, Manivannan Sadhasivam <mani@kernel.org>,
lpieralisi@kernel.org, kwilczynski@kernel.org, heiko@sntech.de,
yue.wang@amlogic.com, pali@kernel.org, neil.armstrong@linaro.org,
robh@kernel.org, jingoohan1@gmail.com, khilman@baylibre.com,
jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
cassel@kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v7 0/2] PCI: Configure Root Port MPS during host probing
Date: Mon, 22 Jun 2026 12:14:48 -0500 [thread overview]
Message-ID: <20260622171448.GA678675@bhelgaas> (raw)
In-Reply-To: <dae17d36-c7d2-467b-a621-3c55e08a67a8@163.com>
On Fri, Jun 19, 2026 at 11:29:39PM +0800, Hans Zhang wrote:
> On 5/6/26 22:00, Manivannan Sadhasivam wrote:
> > On Fri, Nov 28, 2025 at 01:09:06AM +0800, Hans Zhang wrote:
> > > Current PCIe initialization exhibits a key optimization gap: Root Ports
> > > may operate with non-optimal Maximum Payload Size (MPS) settings. While
> > > downstream device configuration is handled during bus enumeration, Root
> > > Port MPS values inherited from firmware or hardware defaults often fail
> > > to utilize the full capabilities supported by controller hardware. This
> > > results in suboptimal data transfer efficiency throughout the PCIe
> > > hierarchy.
> > >
> > > This patch series addresses this by:
> > >
> > > 1. Core PCI enhancement (Patch 1):
> > > - Proactively configures Root Port MPS during host controller probing
> > > - Sets initial MPS to hardware maximum (128 << dev->pcie_mpss)
> > > - Conditional on PCIe bus tuning being enabled (PCIE_BUS_TUNE_OFF unset)
> > > and not in PCIE_BUS_PEER2PEER mode (which requires default 128 bytes)
> > > - Maintains backward compatibility via PCIE_BUS_TUNE_OFF check
> > > - Preserves standard MPS negotiation during downstream enumeration
> > >
> > > 2. Driver cleanup (Patch 2):
> > > - Removes redundant MPS configuration from Meson PCIe controller driver
> > > - Functionality is now centralized in PCI core
> > > - Simplifies driver maintenance long-term
> > >
> >
> > For the series,
> >
> > Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
> >
> > Bjorn: Could you please take a look? This series has been floating for a
> > while...
>
> Hello Bjorn,
>
> Any chance for this series to be applied?
It's too late for v7.2; we're already more than halfway through the
merge window. We can look again for v7.3 after v7.2-rc1.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-06-22 17:14 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-27 17:09 [PATCH v7 0/2] PCI: Configure Root Port MPS during host probing Hans Zhang
2025-11-27 17:09 ` Hans Zhang
2025-11-27 17:09 ` Hans Zhang
2025-11-27 17:09 ` [PATCH v7 1/2] " Hans Zhang
2025-11-27 17:09 ` Hans Zhang
2025-11-27 17:09 ` Hans Zhang
2025-11-27 17:09 ` [PATCH v7 2/2] PCI: dwc: Remove redundant MPS configuration Hans Zhang
2025-11-27 17:09 ` Hans Zhang
2025-11-27 17:09 ` Hans Zhang
2025-12-31 2:58 ` [PATCH v7 0/2] PCI: Configure Root Port MPS during host probing Ricardo Pardini
2025-12-31 2:58 ` Ricardo Pardini
2025-12-31 2:58 ` Ricardo Pardini
2026-01-18 13:26 ` Hans Zhang
2026-01-18 13:26 ` Hans Zhang
2026-01-18 13:26 ` Hans Zhang
2026-02-05 13:28 ` Niklas Cassel
2026-02-05 13:28 ` Niklas Cassel
2026-02-05 13:28 ` Niklas Cassel
2026-01-09 8:38 ` Niklas Cassel
2026-01-09 8:38 ` Niklas Cassel
2026-01-09 8:38 ` Niklas Cassel
2026-05-06 14:00 ` Manivannan Sadhasivam
2026-05-06 14:00 ` Manivannan Sadhasivam
2026-05-06 14:00 ` Manivannan Sadhasivam
2026-06-19 15:29 ` Hans Zhang
2026-06-19 15:29 ` Hans Zhang
2026-06-19 15:29 ` Hans Zhang
2026-06-22 17:14 ` Bjorn Helgaas [this message]
2026-06-22 17:14 ` Bjorn Helgaas
2026-06-22 17:14 ` Bjorn Helgaas
2026-07-14 11:06 ` Hans Zhang
2026-07-14 11:06 ` Hans Zhang
2026-07-14 11:06 ` Hans Zhang
2026-08-18 7:06 ` Niklas Cassel
2026-08-18 7:06 ` Niklas Cassel
2026-08-18 7:06 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260622171448.GA678675@bhelgaas \
--to=helgaas@kernel.org \
--cc=18255117159@163.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=heiko@sntech.de \
--cc=jbrunet@baylibre.com \
--cc=jingoohan1@gmail.com \
--cc=khilman@baylibre.com \
--cc=kwilczynski@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=pali@kernel.org \
--cc=robh@kernel.org \
--cc=yue.wang@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.