From: John Ripple <john.ripple@keysight.com>
To: openembedded-core@lists.openembedded.org
Cc: John Ripple <john.ripple@keysight.com>
Subject: [meta][PATCH v3 1/2] go-vendor.bbclass: Unpack into BP for destsuffix
Date: Mon, 22 Jun 2026 17:03:29 -0600 [thread overview]
Message-ID: <20260622230331.3754496-1-john.ripple@keysight.com> (raw)
The go-vendor class has a hardcoded destsuffix variable used to unpack
sources fetched with the go_src_uri function. This was causing a conflict
with insane.bbclass which prohibts setting S = "${UNPACKDIR}/git" which
was needed to find the vendored sources in the hardcoded location.
Changing this unpack location to use the standard base package name (BP)
fixes the previous issue and no longer requires manually setting S in the
recipes that use go-vendor.
Signed-off-by: John Ripple <john.ripple@keysight.com>
---
meta/classes/go-vendor.bbclass | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/meta/classes/go-vendor.bbclass b/meta/classes/go-vendor.bbclass
index 6ec6178add..f854d14bdf 100644
--- a/meta/classes/go-vendor.bbclass
+++ b/meta/classes/go-vendor.bbclass
@@ -19,7 +19,7 @@ inherit go-mod
def go_src_uri(repo, version, path=None, subdir=None, \
vcs='git', replaces=None, pathmajor=None):
- destsuffix = "git/src/import/vendor.fetch"
+ destsuffix = "${BP}/src/import/vendor.fetch"
module_path = repo if not path else path
src_uri = "{}://{};name={}".format(vcs, repo, module_path.replace('/', '.'))
@@ -58,7 +58,8 @@ python do_go_vendor() {
if not src_uri:
bb.fatal("SRC_URI is empty")
- default_destsuffix = "git/src/import/vendor.fetch"
+ base_package = d.getVar('BP')
+ default_destsuffix = "{}/src/import/vendor.fetch".format(base_package)
fetcher = bb.fetch2.Fetch(src_uri, d)
go_import = d.getVar('GO_IMPORT')
source_dir = d.getVar('S')
next reply other threads:[~2026-06-22 23:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 23:03 John Ripple [this message]
2026-06-22 23:03 ` [meta][PATCH v3 2/2] go-vendor.bbclass: Remove vendor symlink John Ripple
2026-06-26 13:55 ` [OE-core] [meta][PATCH v3 1/2] go-vendor.bbclass: Unpack into BP for destsuffix Ross Burton
2026-06-26 17:20 ` John Ripple
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260622230331.3754496-1-john.ripple@keysight.com \
--to=john.ripple@keysight.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.