From: "John Ripple" <john.ripple@keysight.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [meta][PATCH v3 1/2] go-vendor.bbclass: Unpack into BP for destsuffix
Date: Fri, 26 Jun 2026 10:20:33 -0700 [thread overview]
Message-ID: <79924.1782494433753879942@lists.openembedded.org> (raw)
In-Reply-To: <63E7937C-180C-4D86-AB9F-628D62ED2148@arm.com>
[-- Attachment #1: Type: text/plain, Size: 1302 bytes --]
Hi Ross,
>
>
>> On 23 Jun 2026, at 00:03, John Ripple via lists.openembedded.org
>> <john.ripple=keysight.com@...> wrote:
>>
>> The go-vendor class has a hardcoded destsuffix variable used to unpack
>> sources fetched with the go_src_uri function. This was causing a conflict
>> with insane.bbclass which prohibts setting S = "${UNPACKDIR}/git" which
>> was needed to find the vendored sources in the hardcoded location.
>> Changing this unpack location to use the standard base package name (BP)
>> fixes the previous issue and no longer requires manually setting S in the
>> recipes that use go-vendor.
>
> Thanks for these patches. Sadly we don’t have a test case for the
> go-vendor class, as you clearly use it would you be able to write a small
> test case to verify that a recipe using the go-vendor class works? We can
> host little test repositories on git.yoctoproject.org if needed (for
> example, https://git.yoctoproject.org/recipetool-go-test/ ).
>
Is there anything the test should do in particular or is there a general guides for what should be tested for a bbclass? I'm not very familiar with the Yocto self test framework so any tips or documentation would be appreciated. I'll try to follow what the gotoolchain.py test does if nothing else.
John
[-- Attachment #2: Type: text/html, Size: 1489 bytes --]
prev parent reply other threads:[~2026-06-26 17:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 23:03 [meta][PATCH v3 1/2] go-vendor.bbclass: Unpack into BP for destsuffix John Ripple
2026-06-22 23:03 ` [meta][PATCH v3 2/2] go-vendor.bbclass: Remove vendor symlink John Ripple
2026-06-26 13:55 ` [OE-core] [meta][PATCH v3 1/2] go-vendor.bbclass: Unpack into BP for destsuffix Ross Burton
2026-06-26 17:20 ` John Ripple [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79924.1782494433753879942@lists.openembedded.org \
--to=john.ripple@keysight.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.