* [PATCH] dt-bindings: arm: qcom,ids: Add SoC ID for Snapdragon SDA 850
@ 2026-06-23 18:41 ` David Heidelberg
0 siblings, 0 replies; 3+ messages in thread
From: David Heidelberg via B4 Relay @ 2026-06-23 18:41 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, David Heidelberg
From: David Heidelberg <david@ixit.cz>
Add SoC ID for Qualcomm Snapdragon SDA850.
Signed-off-by: David Heidelberg <david@ixit.cz>
---
Will be used by Comma three.
---
include/dt-bindings/arm/qcom,ids.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
index 1af73c0ad41cd..4b3062f57eecd 100644
--- a/include/dt-bindings/arm/qcom,ids.h
+++ b/include/dt-bindings/arm/qcom,ids.h
@@ -179,16 +179,17 @@
#define QCOM_ID_SDM450 338
#define QCOM_ID_SM8150 339
#define QCOM_ID_SDA845 341
#define QCOM_ID_IPQ8072 342
#define QCOM_ID_IPQ8076 343
#define QCOM_ID_IPQ8078 344
#define QCOM_ID_SDM636 345
#define QCOM_ID_SDA636 346
+#define QCOM_ID_SDA850 348
#define QCOM_ID_SDM632 349
#define QCOM_ID_SDA632 350
#define QCOM_ID_SDA450 351
#define QCOM_ID_SDM439 353
#define QCOM_ID_SDM429 354
#define QCOM_ID_SM8250 356
#define QCOM_ID_SA8155 362
#define QCOM_ID_SDA439 363
---
base-commit: 948efecf22e49aa4bf55bb73ec79a0ddcfd38571
change-id: 20260623-sda850-6b5c1e44662c
Best regards,
--
David Heidelberg <david@ixit.cz>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] dt-bindings: arm: qcom,ids: Add SoC ID for Snapdragon SDA 850
@ 2026-06-23 18:41 ` David Heidelberg
0 siblings, 0 replies; 3+ messages in thread
From: David Heidelberg @ 2026-06-23 18:41 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, David Heidelberg
Add SoC ID for Qualcomm Snapdragon SDA850.
Signed-off-by: David Heidelberg <david@ixit.cz>
---
Will be used by Comma three.
---
include/dt-bindings/arm/qcom,ids.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
index 1af73c0ad41cd..4b3062f57eecd 100644
--- a/include/dt-bindings/arm/qcom,ids.h
+++ b/include/dt-bindings/arm/qcom,ids.h
@@ -179,16 +179,17 @@
#define QCOM_ID_SDM450 338
#define QCOM_ID_SM8150 339
#define QCOM_ID_SDA845 341
#define QCOM_ID_IPQ8072 342
#define QCOM_ID_IPQ8076 343
#define QCOM_ID_IPQ8078 344
#define QCOM_ID_SDM636 345
#define QCOM_ID_SDA636 346
+#define QCOM_ID_SDA850 348
#define QCOM_ID_SDM632 349
#define QCOM_ID_SDA632 350
#define QCOM_ID_SDA450 351
#define QCOM_ID_SDM439 353
#define QCOM_ID_SDM429 354
#define QCOM_ID_SM8250 356
#define QCOM_ID_SA8155 362
#define QCOM_ID_SDA439 363
---
base-commit: 948efecf22e49aa4bf55bb73ec79a0ddcfd38571
change-id: 20260623-sda850-6b5c1e44662c
Best regards,
--
David Heidelberg <david@ixit.cz>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: arm: qcom,ids: Add SoC ID for Snapdragon SDA 850
2026-06-23 18:41 ` David Heidelberg
(?)
@ 2026-06-23 18:48 ` sashiko-bot
-1 siblings, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-06-23 18:48 UTC (permalink / raw)
To: David Heidelberg via B4 Relay; +Cc: robh, conor+dt, devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing SoC ID mapping in the qcom-socinfo driver causes incorrect sysfs machine attribute.
--
commit 40f8c20a8f811ef4d99535abc1be00a3d96ed7b4
Author: David Heidelberg <david@ixit.cz>
dt-bindings: arm: qcom,ids: Add SoC ID for Snapdragon SDA 850
This commit adds the numerical SoC ID (348) for the Qualcomm Snapdragon
SDA850 to the device tree bindings header.
> diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
> index 1af73c0ad41cd..4b3062f57eecd 100644
> --- a/include/dt-bindings/arm/qcom,ids.h
> +++ b/include/dt-bindings/arm/qcom,ids.h
> @@ -184,6 +184,7 @@
> #define QCOM_ID_IPQ8078 344
> #define QCOM_ID_SDM636 345
> #define QCOM_ID_SDA636 346
> +#define QCOM_ID_SDA850 348
[Severity: Medium]
Should this ID also be added to the soc_id[] array in
drivers/soc/qcom/socinfo.c?
Without adding qcom_board_id(SDA850) to the array, socinfo_machine()
will return NULL when the qcom-socinfo driver probes a Snapdragon SDA850
device, because it fails to map the SMEM build ID (348) to a string.
As a result, soc_device_register() will fall back to using
of_machine_read_model(), which exposes the device tree's board model
string in the /sys/devices/soc0/machine sysfs attribute rather than
the expected SoC name.
Does this regression break user-space tools that rely on the
Qualcomm-specific ABI expectation for the machine attribute?
> #define QCOM_ID_SDM632 349
> #define QCOM_ID_SDA632 350
> #define QCOM_ID_SDA450 351
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260623-sda850-v1-1-ddd8e62c85d8@ixit.cz?part=1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-06-23 18:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-23 18:41 [PATCH] dt-bindings: arm: qcom,ids: Add SoC ID for Snapdragon SDA 850 David Heidelberg via B4 Relay
2026-06-23 18:41 ` David Heidelberg
2026-06-23 18:48 ` sashiko-bot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.