Re: [PATCH v2 12/16] perf python: Add thread and PMU uninitialized checks

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added CHECK_INITIALIZED macro in pyrf_pmu__events() leaks the py_list object when the pmu is not initialized.
--

commit 579d96b72f035d8f31919edd0270e2cfa16975d3
Author: Ian Rogers <irogers@google.com>

perf python: Add thread and PMU uninitialized checks

Add CHECK_INITIALIZED checks to the thread attribute getters
(get_pid, get_tid, get_ppid) to prevent crashes if they are accessed
before being properly initialized.

> diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c
> index 71be130b38c53..b17b191b16255 100644
> --- a/tools/perf/util/python.c
> +++ b/tools/perf/util/python.c
[ ... ]
> @@ -1730,6 +1731,8 @@ static PyObject *pyrf_pmu__events(PyObject *self)
>  	PyObject *py_list = PyList_New(0);
>  	int ret;
>  
> +	CHECK_INITIALIZED(ppmu->pmu, "pmu");
> +

[Severity: Medium]
If ppmu->pmu is uninitialized, won't this newly added check return early
and leak the py_list object allocated just above it?

Would it make sense to move the CHECK_INITIALIZED() macro before the
PyList_New(0) allocation?

>  	if (!py_list)
>  		return NULL;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260624051535.3584977-1-irogers@google.com?part=12