Re: [RFC PATCH v1.1 02/11] Docs/ABI/damon: document probe files

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incorrect sysfs value 'memmcg' and typographical errors in DAMON probe ABI documentation.
--

commit 0777dacf66fdc3cce9315b7348cc989aa1d048f8
Author: SeongJae Park <sj@kernel.org>

Docs/ABI/damon: document probe files

This commit updates the DAMON ABI documentation to include the new DAMON
probe sysfs files, defining directories for probes, filters, and attributes.

> diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-damon b/Documentation/ABI/testing/sysfs-kernel-mm-damon
> index b73e6bc28ea5f..2815f6bc05c18 100644
> --- a/Documentation/ABI/testing/sysfs-kernel-mm-damon
> +++ b/Documentation/ABI/testing/sysfs-kernel-mm-damon
[ ... ]
> +What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/monitoring_attrs/probes/<P>/filters/<F>/path
> +Date:		May 2026
> +Contact:	SeongJae Park <sj@kernel.org>
> +Description:	If 'memmcg' is written to the 'type' file, writing to and
> +		reading from this file sets and geets the path to the memory
> +		cgroup of the interest.

[Severity: Medium]
Is the expected type value documented correctly here? The documentation
instructs users to write 'memmcg' to the type file, but the underlying kernel
code strictly expects 'memcg'. If userspace follows this documentation, will
the kernel reject the input with an -EINVAL error?

Also, this isn't a bug, but there is a typo in this sentence where "geets"
is written instead of "gets".

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260625050756.91115-1-sj@kernel.org?part=2