Re: [RFC PATCH v1.1 01/11] Docs/mm/damon/design: update for DAMOS_QUOTA_NODE_ELIGIBLE_MEM_BP

[SeongJae Park <sj@kernel.org>]

On Thu, 25 Jun 2026 05:13:50 +0000 sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The patch introduces an internal inconsistency in the design document by documenting the `node_eligible_mem_bp` metric but failing to update the adjacent sentence that lists which metrics require the `nid` parameter.
> --
> 
> commit 77a1ee91d398d22fd9a42b16bbf085e55f72a94a
> Author: SeongJae Park <sj@kernel.org>
> Docs/mm/damon/design: update for DAMOS_QUOTA_NODE_ELIGIBLE_MEM_BP
> 
> This commit updates the DAMON design document to include the
> node_eligible_mem_bp goal metric that was introduced in an earlier commit.
> 
> > diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst
> > --- a/Documentation/mm/damon/design.rst
> > +++ b/Documentation/mm/damon/design.rst
> > @@ -686,6 +686,8 @@ mechanism tries to make ``current_value`` of ``target_metric`` be same to
> >    (1/10,000).
> >  - ``inactive_mem_bp``: Inactive to active + inactive (LRU) memory size ratio in
> >    bp (1/10,000).
> > +- ``node_eligible_mem_bp``: Scheme target access pattern-eligible memory ratio
> > +  of a node in bp (1/10,000).
> >  
> >  ``nid`` is optionally required for only ``node_mem_used_bp``,
> >  ``node_mem_free_bp``, ``node_memcg_used_bp`` and ``node_memcg_free_bp`` to
> 
> [Severity: Low]
> Since node_eligible_mem_bp is a node-specific metric, should it also be
> added to this list of metrics that optionally require nid? As currently
> written, the use of the word "only" implies that node_eligible_mem_bp does
> not use an nid parameter, which could be misleading for users trying to
> configure this metric.

Good catch!  I will do so in the next revision.


Thanks,
SJ

[...]