* [alternative-merged] mm-hugetlb-init-tails-before-init_migratetype.patch removed from -mm tree
@ 2026-06-26 0:46 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2026-06-26 0:46 UTC (permalink / raw)
To: mm-commits, vbabka, stable, osalvador, muchun.song, kas, david,
mclapinski, akpm
The quilt patch titled
Subject: mm/hugetlb: init tails before init_migratetype
has been removed from the -mm tree. Its filename was
mm-hugetlb-init-tails-before-init_migratetype.patch
This patch was dropped because an alternative patch was or shall be merged
------------------------------------------------------
From: Michal Clapinski <mclapinski@google.com>
Subject: mm/hugetlb: init tails before init_migratetype
Date: Mon, 22 Jun 2026 12:19:01 +0200
Currently, if you enable HVO, DEFERRED_STRUCT_PAGE_INIT and VM_DEBUG the
kernel will crash with the following stack trace
get_pfnblock_bitmap_bitidx
__set_pfnblock_flags_mask
hugetlb_bootmem_init_migratetype
prep_and_add_bootmem_folios
gather_bootmem_prealloc_node
gather_bootmem_prealloc_parallel
padata_do_multithreaded
gather_bootmem_prealloc
hugetlb_init
on this code
VM_BUG_ON_PAGE(!zone_spans_pfn(page_zone(page), pfn), page);
This code looks inside the struct page which will be uninitialized
for hugetlb tail pages, which will cause a false positive.
So let's initialize the tail pages before this happens.
Link: https://lore.kernel.org/20260622101901.223961-1-mclapinski@google.com
Fixes: 622026e87c40 ("mm/hugetlb: remove fake head pages")
Signed-off-by: Michal Clapinski <mclapinski@google.com>
Reviewed-by: Kiryl Shutsemau (Meta) <kas@kernel.org>
Tested-by: Kiryl Shutsemau (Meta) <kas@kernel.org>
Cc: David Hildenbrand <david@kernel.org>
Cc: Michal Clapinski <mclapinski@google.com>
Cc: Muchun Song <muchun.song@linux.dev>
Cc: Oscar Salvador <osalvador@suse.de>
Cc: Vlastimil Babka <vbabka@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/hugetlb.c | 1 +
mm/hugetlb_vmemmap.c | 14 +++++++++-----
mm/hugetlb_vmemmap.h | 5 +++++
3 files changed, 15 insertions(+), 5 deletions(-)
--- a/mm/hugetlb.c~mm-hugetlb-init-tails-before-init_migratetype
+++ a/mm/hugetlb.c
@@ -4127,6 +4127,7 @@ static int __init hugetlb_init(void)
}
hugetlb_init_hstates();
+ hugetlb_vmemmap_init_tails();
gather_bootmem_prealloc();
report_hugepages();
--- a/mm/hugetlb_vmemmap.c~mm-hugetlb-init-tails-before-init_migratetype
+++ a/mm/hugetlb_vmemmap.c
@@ -867,14 +867,10 @@ static const struct ctl_table hugetlb_vm
},
};
-static int __init hugetlb_vmemmap_init(void)
+void __init hugetlb_vmemmap_init_tails(void)
{
- const struct hstate *h;
struct zone *zone;
- /* HUGETLB_VMEMMAP_RESERVE_SIZE should cover all used struct pages */
- BUILD_BUG_ON(__NR_USED_SUBPAGE > HUGETLB_VMEMMAP_RESERVE_PAGES);
-
for_each_zone(zone) {
for (int i = 0; i < NR_VMEMMAP_TAILS; i++) {
struct page *tail, *p;
@@ -890,6 +886,14 @@ static int __init hugetlb_vmemmap_init(v
init_compound_tail(p + j, NULL, order, zone);
}
}
+}
+
+static int __init hugetlb_vmemmap_init(void)
+{
+ const struct hstate *h;
+
+ /* HUGETLB_VMEMMAP_RESERVE_SIZE should cover all used struct pages */
+ BUILD_BUG_ON(__NR_USED_SUBPAGE > HUGETLB_VMEMMAP_RESERVE_PAGES);
for_each_hstate(h) {
if (hugetlb_vmemmap_optimizable(h)) {
--- a/mm/hugetlb_vmemmap.h~mm-hugetlb-init-tails-before-init_migratetype
+++ a/mm/hugetlb_vmemmap.h
@@ -20,6 +20,7 @@
#define HUGETLB_VMEMMAP_RESERVE_PAGES (HUGETLB_VMEMMAP_RESERVE_SIZE / sizeof(struct page))
#ifdef CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP
+void hugetlb_vmemmap_init_tails(void);
int hugetlb_vmemmap_restore_folio(const struct hstate *h, struct folio *folio);
long hugetlb_vmemmap_restore_folios(const struct hstate *h,
struct list_head *folio_list,
@@ -72,6 +73,10 @@ static inline void hugetlb_vmemmap_optim
{
}
+static inline void hugetlb_vmemmap_init_tails(void)
+{
+}
+
static inline void hugetlb_vmemmap_optimize_bootmem_folios(struct hstate *h,
struct list_head *folio_list)
{
_
Patches currently in -mm which might be from mclapinski@google.com are
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-06-26 0:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-26 0:46 [alternative-merged] mm-hugetlb-init-tails-before-init_migratetype.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.