All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Guixin Liu <kanie@linux.alibaba.com>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Chaitanya Kulkarni <kch@nvidia.com>,
	linux-nvme@lists.infradead.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] nvmet: replace sysfs_emit() with sprintf() in configfs show attrs
Date: Fri, 26 Jun 2026 09:01:17 +0200	[thread overview]
Message-ID: <20260626070117.GB11368@lst.de> (raw)
In-Reply-To: <20260622025915.1294806-1-kanie@linux.alibaba.com>


Adding Greg to see if he agrees.

But if we add churn to change this, we should probably switch to
using seq_file for memory safety, and have some generic
configfs-level infrastruture for that.



  reply	other threads:[~2026-06-26  7:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-22  2:59 [PATCH] nvmet: replace sysfs_emit() with sprintf() in configfs show attrs Guixin Liu
2026-06-26  7:01 ` Christoph Hellwig [this message]
2026-06-26  7:53   ` Greg Kroah-Hartman
2026-06-26  9:31     ` Guixin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260626070117.GB11368@lst.de \
    --to=hch@lst.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=kanie@linux.alibaba.com \
    --cc=kch@nvidia.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.