From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Guixin Liu <kanie@linux.alibaba.com>,
Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvmet: replace sysfs_emit() with sprintf() in configfs show attrs
Date: Fri, 26 Jun 2026 08:53:03 +0100 [thread overview]
Message-ID: <2026062614-outthink-drool-fd81@gregkh> (raw)
In-Reply-To: <20260626070117.GB11368@lst.de>
On Fri, Jun 26, 2026 at 09:01:17AM +0200, Christoph Hellwig wrote:
>
> Adding Greg to see if he agrees.
Ick, no, sysfs_emit() should be just fine, and safe, for configfs to
use, please don't do conversions away from it.
> But if we add churn to change this, we should probably switch to
> using seq_file for memory safety, and have some generic
> configfs-level infrastruture for that.
seq_file() would also be great, but really, sysfs_emit() should be all
that you need to use here as you should only have one-value-per-file
with no overflows possible anyway.
thanks,
greg k-h
next prev parent reply other threads:[~2026-06-26 7:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 2:59 [PATCH] nvmet: replace sysfs_emit() with sprintf() in configfs show attrs Guixin Liu
2026-06-26 7:01 ` Christoph Hellwig
2026-06-26 7:53 ` Greg Kroah-Hartman [this message]
2026-06-26 9:31 ` Guixin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026062614-outthink-drool-fd81@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=kanie@linux.alibaba.com \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.