Re: [PATCH 02/14] perf c2c: add function view browser skeleton

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added `perf_c2c__browse_function_view` prototype is guarded by `HAVE_SLANG_SUPPORT` but lacks a dummy inline fallback stub in an `#else` block.
--

commit b142a11979c1d1a680751e23d2fc5169f9d5fc53
Author: Jiebin Sun <jiebin.sun@intel.com>

perf c2c: add function view browser skeleton

This commit adds c2c-function.c with a stub perf_c2c__browse_function_view()
entry point and registers it in the build system. It declares the function
prototype in c2c.h to prepare for function-level cacheline sharing analysis.

> diff --git a/tools/perf/c2c.h b/tools/perf/c2c.h
> index 3e974dd1d7ee6..385709536a1ae 100644
> --- a/tools/perf/c2c.h
> +++ b/tools/perf/c2c.h
> @@ -134,6 +134,7 @@ bool fmt_equal(struct perf_hpp_fmt *a, struct perf_hpp_fmt *b);
>  
>  #ifdef HAVE_SLANG_SUPPORT
>  int perf_c2c__browse_cacheline(struct hist_entry *he);
> +int perf_c2c__browse_function_view(struct hists *hists);

[Severity: Low]
Should this prototype have a dummy inline fallback stub in an #else block?
Without a dummy fallback stub, any unguarded call to
perf_c2c__browse_function_view() on a system lacking slang support might result
in a build failure.

>  #endif
>  
>  #endif /* _PERF_C2C_H_ */

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260626070355.1556721-1-jiebin.sun@intel.com?part=2