Re: [PATCH 03/14] perf c2c: add function view type definitions and helpers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `symbol_name_equal` helper relies on host-bound `arch__compare_symbol_names()`, which breaks cross-platform analysis for the c2c function view.
--

commit a7beef2e1248ae5cd6dc127b26c6803a87eb9dd4
Author: Jiebin Sun <jiebin.sun@intel.com>

perf c2c: add function view type definitions and helpers

Add the foundational type definitions and helper functions for the
function view browser.

> diff --git a/tools/perf/ui/browsers/c2c-function.c b/tools/perf/ui/browsers/c2c-function.c
> index 040266288be3d..dbc912a4a242b 100644
> --- a/tools/perf/ui/browsers/c2c-function.c
> +++ b/tools/perf/ui/browsers/c2c-function.c
[ ... ]
> +static __maybe_unused inline bool symbol_name_equal(struct symbol *a, struct symbol *b)
> +{
> +	return a && b && arch__compare_symbol_names(a->name, b->name) == 0;

[Severity: Medium]
Does this break cross-platform analysis for the c2c function view?

Calling arch__compare_symbol_names() relies on a weak symbol bound to the host
architecture at compile time, since files in tools/perf/arch/ are conditionally
linked based on the build machine.

If a user runs perf c2c on an x86 host to analyze a perf.data file recorded on
PowerPC, this falls back to strcmp(). Can this result in failing to correctly
group identical symbols that have architecture-specific variations (like
PowerPC's .my_func vs my_func)?

Should this dynamically query the e_machine of the analyzed perf.data file
instead of relying on host-bound architecture functions?

> +}
> +
> +static __maybe_unused inline u64 hist_entry__iaddr(struct hist_entry *he)

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260626070355.1556721-1-jiebin.sun@intel.com?part=3