[PATCH v2 0/3] iio: light: al3xxx: add missing REGMAP_I2C to Kconfig entries

[PATCH v2 0/3] iio: light: al3xxx: add missing REGMAP_I2C to Kconfig entries

[Joshua Crofts]

This series adds REGMAP_I2C support to three AL3xxx ambient light
sensors that were previously missing this dependency, causing build
failures.

To reproduce the build failure, run `make allnoconfig` and `make menuconfig`
in which you select IIO, I2C and any AL3xxx sensor and `make .` will
fail with errors such as:

drivers/iio/light/al3010.c: In function ‘al3010_probe’:
drivers/iio/light/al3010.c:185:24: error: implicit declaration of function ‘devm_regmap_init_i2c’ [-Wimplicit-function-declaration]
  185 |         data->regmap = devm_regmap_init_i2c(client, &al3010_regmap_config);
      |                        ^~~~~~~~~~~~~~~~~~~~
drivers/iio/light/al3010.c:185:22: error: assignment to ‘struct regmap *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
  185 |         data->regmap = devm_regmap_init_i2c(client, &al3010_regmap_config);
      |                      ^
drivers/iio/light/al3010.c: At top level:
drivers/iio/light/al3010.c:48:35: error: storage size of ‘al3010_regmap_config’ isn’t known
   48 | static const struct regmap_config al3010_regmap_config = {
      |                                   ^~~~~~~~~~~~~~~~~~~~

I made a separate commit for each driver, to ensure a proper Fixes:
tag is appended for easy backporting. Let me know if you prefer
squashing!

Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
Changes in v2:
- Change select keyword in commit message to lowercase
- Add example steps to reproduce build failure
- Link to v1: https://lore.kernel.org/r/20260625-fix-al3xxx-kconfig-v1-0-d41cbc0c3cf4@gmail.com

---
Joshua Crofts (3):
      iio: light: al3000a: add missing REGMAP_I2C to Kconfig
      iio: light: al3010: add missing REGMAP_I2C to Kconfig
      iio: light: al3320a: add missing REGMAP_I2C to Kconfig

 drivers/iio/light/Kconfig | 3 +++
 1 file changed, 3 insertions(+)
---
base-commit: 7667a80340e99fd45357d0c90ae05813b01bbfef
change-id: 20260625-fix-al3xxx-kconfig-ddb1f00a2615

Best regards,
-- 
Kind regards

CJD

[PATCH v2 1/3] iio: light: al3000a: add missing REGMAP_I2C to Kconfig

[Joshua Crofts]

The KConfig entry for the al3000a is missing a `select REGMAP_I2C`,
causing build failures.

Fixes: d531b9f78949 ("iio: light: Add support for AL3000a illuminance sensor")
Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
 drivers/iio/light/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig
index ef36824f312f..a33920568904 100644
--- a/drivers/iio/light/Kconfig
+++ b/drivers/iio/light/Kconfig
@@ -45,6 +45,7 @@ config ADUX1020
 
 config AL3000A
 	tristate "AL3000a ambient light sensor"
+	select REGMAP_I2C
 	depends on I2C
 	help
 	  Say Y here if you want to build a driver for the Dyna Image AL3000a

-- 
2.54.0

[PATCH v2 2/3] iio: light: al3010: add missing REGMAP_I2C to Kconfig

[Joshua Crofts]

The KConfig entry for the AL3010 is missing a `select REGMAP_I2C`,
causing build failures.

Fixes: 0e5e21e23dd6 ("iio: light: al3010: Implement regmap support")
Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
 drivers/iio/light/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig
index a33920568904..4ba3151ebea7 100644
--- a/drivers/iio/light/Kconfig
+++ b/drivers/iio/light/Kconfig
@@ -56,6 +56,7 @@ config AL3000A
 
 config AL3010
 	tristate "AL3010 ambient light sensor"
+	select REGMAP_I2C
 	depends on I2C
 	help
 	  Say Y here if you want to build a driver for the Dyna Image AL3010

-- 
2.54.0

[PATCH v2 3/3] iio: light: al3320a: add missing REGMAP_I2C to Kconfig

[Joshua Crofts]

The Kconfig entry for the al3320a is missing a `select REGMAP_I2C`,
causing build failures.

Fixes: 1850e6ae7f91 ("iio: light: al3320a: Implement regmap support")
Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
 drivers/iio/light/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig
index 4ba3151ebea7..f23bbce12c72 100644
--- a/drivers/iio/light/Kconfig
+++ b/drivers/iio/light/Kconfig
@@ -67,6 +67,7 @@ config AL3010
 
 config AL3320A
 	tristate "AL3320A ambient light sensor"
+	select REGMAP_I2C
 	depends on I2C
 	help
 	  Say Y here if you want to build a driver for the Dyna Image AL3320A

-- 
2.54.0

Re: [PATCH v2 0/3] iio: light: al3xxx: add missing REGMAP_I2C to Kconfig entries

[David Heidelberg]

On 25/06/2026 21:38, Joshua Crofts wrote:
> This series adds REGMAP_I2C support to three AL3xxx ambient light
> sensors that were previously missing this dependency, causing build
> failures.
> 
> To reproduce the build failure, run `make allnoconfig` and `make menuconfig`
> in which you select IIO, I2C and any AL3xxx sensor and `make .` will
> fail with errors such as:
> 
> drivers/iio/light/al3010.c: In function ‘al3010_probe’:
> drivers/iio/light/al3010.c:185:24: error: implicit declaration of function ‘devm_regmap_init_i2c’ [-Wimplicit-function-declaration]
>    185 |         data->regmap = devm_regmap_init_i2c(client, &al3010_regmap_config);
>        |                        ^~~~~~~~~~~~~~~~~~~~
> drivers/iio/light/al3010.c:185:22: error: assignment to ‘struct regmap *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
>    185 |         data->regmap = devm_regmap_init_i2c(client, &al3010_regmap_config);
>        |                      ^
> drivers/iio/light/al3010.c: At top level:
> drivers/iio/light/al3010.c:48:35: error: storage size of ‘al3010_regmap_config’ isn’t known
>     48 | static const struct regmap_config al3010_regmap_config = {
>        |                                   ^~~~~~~~~~~~~~~~~~~~
> 
> I made a separate commit for each driver, to ensure a proper Fixes:
> tag is appended for easy backporting. Let me know if you prefer
> squashing!
> 
> Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
> ---
> Changes in v2:
> - Change select keyword in commit message to lowercase
> - Add example steps to reproduce build failure
> - Link to v1: https://lore.kernel.org/r/20260625-fix-al3xxx-kconfig-v1-0-d41cbc0c3cf4@gmail.com
> 
> ---
> Joshua Crofts (3):
>        iio: light: al3000a: add missing REGMAP_I2C to Kconfig
>        iio: light: al3010: add missing REGMAP_I2C to Kconfig
>        iio: light: al3320a: add missing REGMAP_I2C to Kconfig
> 
>   drivers/iio/light/Kconfig | 3 +++
>   1 file changed, 3 insertions(+)
> ---
> base-commit: 7667a80340e99fd45357d0c90ae05813b01bbfef
> change-id: 20260625-fix-al3xxx-kconfig-ddb1f00a2615
> 
> Best regards,

Whole series,

Reviewed-by: David Heidelberg <david@ixit.cz>

Thank you

Re: [PATCH v2 0/3] iio: light: al3xxx: add missing REGMAP_I2C to Kconfig entries

[Andy Shevchenko]

On Thu, Jun 25, 2026 at 09:38:07PM +0200, Joshua Crofts wrote:
> This series adds REGMAP_I2C support to three AL3xxx ambient light
> sensors that were previously missing this dependency, causing build
> failures.
> 
> To reproduce the build failure, run `make allnoconfig` and `make menuconfig`
> in which you select IIO, I2C and any AL3xxx sensor and `make .` will
> fail with errors such as:
> 
> drivers/iio/light/al3010.c: In function ‘al3010_probe’:
> drivers/iio/light/al3010.c:185:24: error: implicit declaration of function ‘devm_regmap_init_i2c’ [-Wimplicit-function-declaration]
>   185 |         data->regmap = devm_regmap_init_i2c(client, &al3010_regmap_config);
>       |                        ^~~~~~~~~~~~~~~~~~~~
> drivers/iio/light/al3010.c:185:22: error: assignment to ‘struct regmap *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
>   185 |         data->regmap = devm_regmap_init_i2c(client, &al3010_regmap_config);
>       |                      ^
> drivers/iio/light/al3010.c: At top level:
> drivers/iio/light/al3010.c:48:35: error: storage size of ‘al3010_regmap_config’ isn’t known
>    48 | static const struct regmap_config al3010_regmap_config = {
>       |                                   ^~~~~~~~~~~~~~~~~~~~

Now all is better. The only thing is missing is Cc: stable@ line.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

> I made a separate commit for each driver, to ensure a proper Fixes:
> tag is appended for easy backporting. Let me know if you prefer
> squashing!

I prefer per-driver patches, but let Jonathan to handle that.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 0/3] iio: light: al3xxx: add missing REGMAP_I2C to Kconfig entries

[Joshua Crofts]

On Fri, 26 Jun 2026 15:26:06 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> > drivers/iio/light/al3010.c: At top level:
> > drivers/iio/light/al3010.c:48:35: error: storage size of ‘al3010_regmap_config’ isn’t known
> >    48 | static const struct regmap_config al3010_regmap_config = {
> >       |                                   ^~~~~~~~~~~~~~~~~~~~  
> 
> Now all is better. The only thing is missing is Cc: stable@ line.

I knew I was missing something - must be the heat!

Hopefully Jonathan can mark it for stable while applying.

-- 
Kind regards

CJD

Re: [PATCH v2 0/3] iio: light: al3xxx: add missing REGMAP_I2C to Kconfig entries

[Nuno Sá]

On Fri, Jun 26, 2026 at 03:26:06PM +0300, Andy Shevchenko wrote:
> On Thu, Jun 25, 2026 at 09:38:07PM +0200, Joshua Crofts wrote:
> > This series adds REGMAP_I2C support to three AL3xxx ambient light
> > sensors that were previously missing this dependency, causing build
> > failures.
> > 
> > To reproduce the build failure, run `make allnoconfig` and `make menuconfig`
> > in which you select IIO, I2C and any AL3xxx sensor and `make .` will
> > fail with errors such as:
> > 
> > drivers/iio/light/al3010.c: In function ‘al3010_probe’:
> > drivers/iio/light/al3010.c:185:24: error: implicit declaration of function ‘devm_regmap_init_i2c’ [-Wimplicit-function-declaration]
> >   185 |         data->regmap = devm_regmap_init_i2c(client, &al3010_regmap_config);
> >       |                        ^~~~~~~~~~~~~~~~~~~~
> > drivers/iio/light/al3010.c:185:22: error: assignment to ‘struct regmap *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
> >   185 |         data->regmap = devm_regmap_init_i2c(client, &al3010_regmap_config);
> >       |                      ^
> > drivers/iio/light/al3010.c: At top level:
> > drivers/iio/light/al3010.c:48:35: error: storage size of ‘al3010_regmap_config’ isn’t known
> >    48 | static const struct regmap_config al3010_regmap_config = {
> >       |                                   ^~~~~~~~~~~~~~~~~~~~
> 
> Now all is better. The only thing is missing is Cc: stable@ line.

I'm not sure we have a defined policy for that in IIO. Now that you
mention it, maybe time to ask...

My understanding always was that Jonathan takes care of Ccing stable
but maybe he just does it and being nice about it, does not complain :).

So, Jonathan,

Should the sender take care about Cc or not? Or it does not really matter
:)?

- Nuno Sá

> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> 
> > I made a separate commit for each driver, to ensure a proper Fixes:
> > tag is appended for easy backporting. Let me know if you prefer
> > squashing!
> 
> I prefer per-driver patches, but let Jonathan to handle that.
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 

Re: [PATCH v2 0/3] iio: light: al3xxx: add missing REGMAP_I2C to Kconfig entries

[Andy Shevchenko]

On Fri, Jun 26, 2026 at 4:56 PM Nuno Sá <noname.nuno@gmail.com> wrote:
> On Fri, Jun 26, 2026 at 03:26:06PM +0300, Andy Shevchenko wrote:
> > On Thu, Jun 25, 2026 at 09:38:07PM +0200, Joshua Crofts wrote:

...

> > Now all is better. The only thing is missing is Cc: stable@ line.
>
> I'm not sure we have a defined policy for that in IIO. Now that you
> mention it, maybe time to ask...
>
> My understanding always was that Jonathan takes care of Ccing stable
> but maybe he just does it and being nice about it, does not complain :).

This is the stable Linux kernel policy, it's superior to subsystem ones.

> So, Jonathan,
>
> Should the sender take care about Cc or not? Or it does not really matter
> :)?


-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 0/3] iio: light: al3xxx: add missing REGMAP_I2C to Kconfig entries

[Joshua Crofts]

On Fri, 26 Jun 2026 14:57:05 +0100
Nuno Sá <noname.nuno@gmail.com> wrote:
> I'm not sure we have a defined policy for that in IIO. Now that you
> mention it, maybe time to ask...
> 
> My understanding always was that Jonathan takes care of Ccing stable
> but maybe he just does it and being nice about it, does not complain :).
> 
> So, Jonathan,
> 
> Should the sender take care about Cc or not? Or it does not really matter
> :)?

I always add a Cc: stable when submitting bugfixes, only this time I
forgot :P In the end Jonathan decides whether it should be marked for
stable so he can just remove the tag if the fix isn't backport-worthy.

-- 
Kind regards

CJD