Re: [PATCH v2 5/8] dt-bindings: iio: adc: add ti,ads122c14

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1129 bytes --]

On Fri, Jun 26, 2026 at 01:35:22PM -0500, David Lechner wrote:

> >> +required:
> >> +  - compatible
> > 
> > reg?
> 
> I thought reg being required by i2c-controller.yaml was already good enough.
> 
> https://github.com/devicetree-org/dt-schema/blob/2203c1720f4ebeebd7f8d10e9dc1812993482fab/dtschema/schemas/i2c/i2c-controller.yaml#L219

Nothing mandates that this is a device on a bus at all without requiring
reg, since that's a schema applied by the parent.
It's unlikely that that will actually occur, but I think properties
mandated by schema that are not referenced in a binding should be
required by the binding.

> 
> > 
> >> +  - avdd-supply
> >> +  - dvdd-supply
> >> +
> >> +dependencies:
> >> +  refn-supply: [ refp-supply ]
> >> +
> >> +oneOf:
> >> +  - required: [ refp-supply ]
> >> +  - required: [ "ti,refp-refn-resistor-ohms" ]
> >> +  - properties:
> >> +      refp-supply: false
> >> +      refn-supply: false
> >> +      ti,refp-refn-resistor-ohms: false
> > 
> > I assume you've tested this to make sure it enforces the behaviour that
> > you want?
> 
> 
> yes

:) 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]