From: "Kurt Borja" <kuurtb@gmail.com>
To: "David Lechner" <dlechner@baylibre.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>
Cc: "Chris Hall" <c-hall@ti.com>, "Patrick Edwards" <pedwards@ti.com>,
"Kurt Borja" <kuurtb@gmail.com>,
"Nguyen Minh Tien" <zizuzacker@gmail.com>,
<linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/8] dt-bindings: iio: adc: Add reference-sources property
Date: Mon, 29 Jun 2026 01:47:35 -0500 [thread overview]
Message-ID: <DJLBYI4V0I6Z.2ZMJOFAZXG10L@gmail.com> (raw)
In-Reply-To: <20260625-iio-adc-ti-ads122c14-v2-1-ceb9b0b561cb@baylibre.com>
On Thu Jun 25, 2026 at 4:55 PM -05, David Lechner wrote:
> From: Kurt Borja <kuurtb@gmail.com>
>
> Some ADCs have configurable voltage reference sources for each channel.
>
> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
> Signed-off-by: David Lechner (TI) <dlechner@baylibre.com>
> ---
> v2 changes (compared to Kurt's RFC v2):
> * Drop maxItems.
> * Drop 2nd paragraph of description.
> * Make reference-sources plural since it is an array.
> ---
> Documentation/devicetree/bindings/iio/adc/adc.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adc.yaml b/Documentation/devicetree/bindings/iio/adc/adc.yaml
> index b9bc02b5b07a..12800737d4fb 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adc.yaml
> @@ -73,6 +73,14 @@ properties:
> device design and can interact with other characteristics such as
> settling time.
>
> + reference-sources:
> + $ref: /schemas/types.yaml#/definitions/string-array
> + minItems: 1
Is minItems necessary here? Its causing dt_binding_check to fail:
ti,ads1262.example.dtb: adc@0 (ti,ads1263): channel@0:reference-sources: ['ain2', 'ain3', 'ain2-ain3'] is too long
I don't really know why, but removing it fixes it and allows various
array lengths.
> + description:
> + Indicates the voltage reference source or sources for this channel. Some
> + ADCs usually allow choosing between internal reference sources or a pair
> + of external pins.
> +
> anyOf:
> - oneOf:
> - required:
--
Thanks,
~ Kurt
next prev parent reply other threads:[~2026-06-29 6:47 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-25 21:55 [PATCH v2 0/8] iio: adc: new ti-ads112c14 driver David Lechner
2026-06-25 21:55 ` [PATCH v2 1/8] dt-bindings: iio: adc: Add reference-sources property David Lechner
2026-06-26 16:12 ` Conor Dooley
2026-06-29 6:47 ` Kurt Borja [this message]
2026-06-25 21:55 ` [PATCH v2 2/8] dt-bindings: iio: adc: Add excitation current sources properties David Lechner
2026-06-26 16:10 ` Conor Dooley
2026-07-01 19:39 ` Jonathan Cameron
2026-07-01 22:07 ` David Lechner
2026-06-25 21:55 ` [PATCH v2 3/8] dt-bindings: iio: adc: Add burn-out current properties David Lechner
2026-06-26 16:12 ` Conor Dooley
2026-06-25 21:55 ` [PATCH v2 4/8] dt-bindings: iio: adc: add input-channel-rotation property David Lechner (TI)
2026-06-26 16:14 ` Conor Dooley
2026-06-26 18:27 ` David Lechner
2026-07-01 19:41 ` Jonathan Cameron
2026-07-02 18:58 ` Conor Dooley
2026-07-02 19:30 ` Jonathan Cameron
2026-06-25 21:55 ` [PATCH v2 5/8] dt-bindings: iio: adc: add ti,ads122c14 David Lechner (TI)
2026-06-25 22:12 ` sashiko-bot
2026-06-26 16:18 ` Conor Dooley
2026-06-26 18:35 ` David Lechner
2026-06-27 14:03 ` Conor Dooley
2026-07-01 19:50 ` Jonathan Cameron
2026-06-25 21:55 ` [PATCH v2 6/8] iio: adc: add ti-ads112c14 driver David Lechner (TI)
2026-06-25 22:07 ` sashiko-bot
2026-07-01 19:59 ` Jonathan Cameron
2026-06-25 21:55 ` [PATCH v2 7/8] iio: adc: ti-ads112c14: implement gain on internal short SYS_MON channel David Lechner (TI)
2026-06-25 22:08 ` sashiko-bot
2026-07-01 20:02 ` Jonathan Cameron
2026-06-25 21:55 ` [PATCH v2 8/8] iio: adc: ti-ads112c14: add measurement channel support David Lechner (TI)
2026-06-25 22:11 ` sashiko-bot
2026-07-01 20:20 ` Jonathan Cameron
2026-07-02 9:18 ` Andy Shevchenko
2026-07-02 14:18 ` David Lechner
2026-07-02 19:10 ` Jonathan Cameron
2026-07-03 5:55 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJLBYI4V0I6Z.2ZMJOFAZXG10L@gmail.com \
--to=kuurtb@gmail.com \
--cc=andy@kernel.org \
--cc=c-hall@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=pedwards@ti.com \
--cc=robh@kernel.org \
--cc=zizuzacker@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.