Re: [PATCH v5 08/38] drm/vkms: Add error handling in plane config creation

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `__must_check` attribute was added to the function definition but omitted from the function declaration in the header file.
--

commit b58f544faddd7341ba3d5a39105fac34d6c709cf
Author: Louis Chauvet <louis.chauvet@bootlin.com>

drm/vkms: Add error handling in plane config creation

This commit updates vkms_config_create_plane() to return proper error codes
using ERR_PTR instead of returning NULL on failure. It also adds the
__must_check attribute to the function definition.

> diff --git a/drivers/gpu/drm/vkms/vkms_config.c b/drivers/gpu/drm/vkms/vkms_config.c
> index 5a654d6dead84..1fd2ed1167c54 100644
> --- a/drivers/gpu/drm/vkms/vkms_config.c
> +++ b/drivers/gpu/drm/vkms/vkms_config.c
[ ... ]
> @@ -384,13 +384,16 @@ void vkms_config_register_debugfs(struct vkms_device *vkms_device)
>  			      ARRAY_SIZE(vkms_config_debugfs_list));
>  }
>  
> -struct vkms_config_plane *vkms_config_create_plane(struct vkms_config *config)
> +struct vkms_config_plane __must_check *vkms_config_create_plane(struct vkms_config *config)

[Severity: Low]
Does the __must_check attribute also need to be added to the function
declaration in drivers/gpu/drm/vkms/vkms_config.h?

Since the attribute is only present on the definition here in vkms_config.c,
callers in other translation units won't see it. The compiler will not emit
a warning if the return value is ignored by external callers.

>  {
>  	struct vkms_config_plane *plane_cfg;
> +	int ret;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260627-vkms-all-config-v5-0-854aa0840926@bootlin.com?part=8