Re: [PATCH v5 28/38] drm/vkms: Introduce configfs for connector type

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The configfs show method `connector_type_show` does not append a newline character to its output.
--

commit fa7352c404d21d848225a9615b7a1039d2636d9c
Author: Louis Chauvet <louis.chauvet@bootlin.com>

drm/vkms: Introduce configfs for connector type

This commit adds a new configfs attribute to allow configuring the connector 
type in VKMS. It updates both the configfs interface and the corresponding
documentation.

> diff --git a/drivers/gpu/drm/vkms/vkms_configfs.c b/drivers/gpu/drm/vkms/vkms_configfs.c
> index 95f4594fb683d..8b414f1950e8e 100644
> --- a/drivers/gpu/drm/vkms/vkms_configfs.c
> +++ b/drivers/gpu/drm/vkms/vkms_configfs.c
[ ... ]
> @@ -1117,10 +1117,75 @@ static ssize_t connector_status_store(struct config_item *item,
>  	return (ssize_t)count;
>  }
>  
> +static ssize_t connector_type_show(struct config_item *item, char *page)
> +{
> +	struct vkms_configfs_connector *connector;
> +	int type;
> +
> +	connector = connector_item_to_vkms_configfs_connector(item);
> +
> +	scoped_guard(mutex, &connector->dev->lock) {
> +		type = vkms_config_connector_get_type(connector->config);
> +	}
> +
> +	return sprintf(page, "%u", type);

[Severity: Low]
Does this output need a trailing newline? Configfs attributes typically
include a newline (e.g., "%u\n") to ensure the output is formatted properly
when read from userspace using command-line tools like cat.

> +}
> +
> +static ssize_t connector_type_store(struct config_item *item,
> +				    const char *page, size_t count)
> +{
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260627-vkms-all-config-v5-0-854aa0840926@bootlin.com?part=28