[PATCH 0/3] hwmon: (various) add missing `select REGMAP` to Kconfig

[PATCH 0/3] hwmon: (various) add missing `select REGMAP` to Kconfig

[Joshua Crofts]

This series adds missing `select REGMAP` and `select REGMAP_I2C` to the
MAX6679/MAX1619/LTC2992 Kconfig entries. Without these, some builds may
result in a failure.

Steps to reproduce build failure:
1. Run `make allnoconfig`.
2. Run `make menuconfig` and select I2C, hwmon and any of said drivers.
3. Run `make .` and make will end with regmap-related errors.

Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
Joshua Crofts (3):
      hwmon: (max1619) add missing 'select REGMAP' to Kconfig
      hwmon: (ltc2992) add missing 'select REGMAP_I2C' to Kconfig
      hwmon: (max6679) add missing 'select REGMAP_I2C' to Kconfig

 drivers/hwmon/Kconfig | 3 +++
 1 file changed, 3 insertions(+)
---
base-commit: 446bf1ecbaeceb72d85553ce0ac0e6afc03ec5ca
change-id: 20260629-add-kconfig-deps-1a76039f5409

Best regards,
-- 
Kind regards

CJD

[PATCH 1/3] hwmon: (max1619) add missing 'select REGMAP' to Kconfig

[Joshua Crofts]

The Kconfig entry for the MAX1619 sensor doesn't contain a
`select REGMAP` parameter, causing build failures if regmap
isn't selected previously during the build process.

Fixes: f8016132ce49 ("hwmon: (max1619) Convert to use regmap")
Cc: stable@vger.kernel.org
Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
 drivers/hwmon/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 5c2d3ff5fce8..a908e22bf166 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -1248,6 +1248,7 @@ config SENSORS_MAX16065
 config SENSORS_MAX1619
 	tristate "Maxim MAX1619 sensor chip"
 	depends on I2C
+	select REGMAP
 	help
 	  If you say yes here you get support for MAX1619 sensor chip.
 

-- 
2.54.0

Re: [PATCH 1/3] hwmon: (max1619) add missing 'select REGMAP' to Kconfig

[sashiko-bot]

> The Kconfig entry for the MAX1619 sensor doesn't contain a
> `select REGMAP` parameter, causing build failures if regmap
> isn't selected previously during the build process.
> 
> Fixes: f8016132ce49 ("hwmon: (max1619) Convert to use regmap")
> Cc: stable@vger.kernel.org
> Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629-add-kconfig-deps-v1-0-8104df929b1a@gmail.com?part=1

Re: [PATCH 1/3] hwmon: (max1619) add missing 'select REGMAP' to Kconfig

[Guenter Roeck]

On Mon, Jun 29, 2026 at 09:17:39PM +0200, Joshua Crofts wrote:
> The Kconfig entry for the MAX1619 sensor doesn't contain a
> `select REGMAP` parameter, causing build failures if regmap
> isn't selected previously during the build process.
> 
> Fixes: f8016132ce49 ("hwmon: (max1619) Convert to use regmap")
> Cc: stable@vger.kernel.org
> Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>

Applied.

Thanks,
Guenter

[PATCH 2/3] hwmon: (ltc2992) add missing 'select REGMAP_I2C' to Kconfig

[Joshua Crofts]

The Kconfig entry for the LTC2992 sensor doesn't contain a
`select REGMAP_I2C` parameter, causing build failures if regmap
isn't selected previously during the build process.

Fixes: b0bd407e94b0 ("hwmon: (ltc2992) Add support")
Cc: stable@vger.kernel.org
Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
 drivers/hwmon/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index a908e22bf166..cc593fbfa4cc 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -1098,6 +1098,7 @@ config SENSORS_LTC2992
 	tristate "Linear Technology LTC2992"
 	depends on I2C
 	depends on GPIOLIB
+	select REGMAP_I2C
 	help
 	  If you say yes here you get support for Linear Technology LTC2992
 	  I2C System Monitor. The LTC2992 measures current, voltage, and

-- 
2.54.0

Re: [PATCH 2/3] hwmon: (ltc2992) add missing 'select REGMAP_I2C' to Kconfig

[sashiko-bot]

> The Kconfig entry for the LTC2992 sensor doesn't contain a
> `select REGMAP_I2C` parameter, causing build failures if regmap
> isn't selected previously during the build process.
> 
> Fixes: b0bd407e94b0 ("hwmon: (ltc2992) Add support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629-add-kconfig-deps-v1-0-8104df929b1a@gmail.com?part=2

Re: [PATCH 2/3] hwmon: (ltc2992) add missing 'select REGMAP_I2C' to Kconfig

[Guenter Roeck]

On Mon, Jun 29, 2026 at 09:17:40PM +0200, Joshua Crofts wrote:
> The Kconfig entry for the LTC2992 sensor doesn't contain a
> `select REGMAP_I2C` parameter, causing build failures if regmap
> isn't selected previously during the build process.
> 
> Fixes: b0bd407e94b0 ("hwmon: (ltc2992) Add support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>

Applied.

Thanks,
Guenter

[PATCH 3/3] hwmon: (max6679) add missing 'select REGMAP_I2C' to Kconfig

[Joshua Crofts]

The Kconfig entry for the MAX6679 sensor doesn't contain a
`select REGMAP_I2C` parameter, causing build failures if regmap
isn't selected previously during the build process.

Fixes: 3a2a8cc3fe24 ("hwmon: (max6697) Convert to use regmap")
Cc: stable@vger.kernel.org
Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
 drivers/hwmon/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index cc593fbfa4cc..2bfbcc033d59 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -1368,6 +1368,7 @@ config SENSORS_MAX6650
 config SENSORS_MAX6697
 	tristate "Maxim MAX6697 and compatibles"
 	depends on I2C
+	select REGMAP_I2C
 	help
 	  If you say yes here you get support for MAX6581, MAX6602, MAX6622,
 	  MAX6636, MAX6689, MAX6693, MAX6694, MAX6697, MAX6698, and MAX6699

-- 
2.54.0

Re: [PATCH 3/3] hwmon: (max6679) add missing 'select REGMAP_I2C' to Kconfig

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message incorrectly references 'max6679' instead of 'max6697'.
--

commit 232f529a8bd06a5a57ba2d3974e729ff7df2ae67
Author: Joshua Crofts <joshua.crofts1@gmail.com>

hwmon: (max6679) add missing 'select REGMAP_I2C' to Kconfig

This commit adds a missing REGMAP_I2C selection to a Kconfig entry to prevent
potential build failures when regmap has not been previously selected.

> hwmon: (max6679) add missing 'select REGMAP_I2C' to Kconfig
>
> The Kconfig entry for the MAX6679 sensor doesn't contain a
> `select REGMAP_I2C` parameter, causing build failures if regmap

[Severity: Low]
This isn't a bug, but there appears to be a typo referencing max6679 and
MAX6679 in the commit subject and body. The code changes modify the entry for
SENSORS_MAX6697, and the Fixes tag also correctly notes max6697. Should the
commit message be updated to max6697 to accurately reflect the configuration it
modifies?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629-add-kconfig-deps-v1-0-8104df929b1a@gmail.com?part=3

Re: [PATCH 3/3] hwmon: (max6679) add missing 'select REGMAP_I2C' to Kconfig

[Joshua Crofts]

On Mon, 29 Jun 2026 at 21:17, Joshua Crofts <joshua.crofts1@gmail.com> wrote:
>
> The Kconfig entry for the MAX6679 sensor doesn't contain a
> `select REGMAP_I2C` parameter, causing build failures if regmap
> isn't selected previously during the build process.

Oops, typo in the commit message, it should be 6697 in the title and
body. Shall I send
a new version or can it be tweaked when applying?

-- 
Kind regards

CJD

Re: [PATCH 3/3] hwmon: (max6679) add missing 'select REGMAP_I2C' to Kconfig

[Guenter Roeck]

On Mon, Jun 29, 2026 at 09:17:41PM +0200, Joshua Crofts wrote:
> The Kconfig entry for the MAX6679 sensor doesn't contain a
> `select REGMAP_I2C` parameter, causing build failures if regmap
> isn't selected previously during the build process.
> 
> Fixes: 3a2a8cc3fe24 ("hwmon: (max6697) Convert to use regmap")
> Cc: stable@vger.kernel.org
> Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>

Applied, after fixing 6679 --> 6697.

Thanks,
Guenter

> ---
>  drivers/hwmon/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index cc593fbfa4cc..2bfbcc033d59 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -1368,6 +1368,7 @@ config SENSORS_MAX6650
>  config SENSORS_MAX6697
>  	tristate "Maxim MAX6697 and compatibles"
>  	depends on I2C
> +	select REGMAP_I2C
>  	help
>  	  If you say yes here you get support for MAX6581, MAX6602, MAX6622,
>  	  MAX6636, MAX6689, MAX6693, MAX6694, MAX6697, MAX6698, and MAX6699