* [PATCHv2 net-next] net: dsa: qca8k: fall back to ethernet-ports node name for LEDs
@ 2026-06-30 1:51 Rosen Penev
2026-07-02 20:43 ` Andrew Lunn
2026-07-03 6:14 ` Paolo Abeni
0 siblings, 2 replies; 3+ messages in thread
From: Rosen Penev @ 2026-06-30 1:51 UTC (permalink / raw)
To: netdev
Cc: Andrew Lunn, Vladimir Oltean, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, open list
The device tree binding allows both "ports" and "ethernet-ports" as
the container node name. Try "ethernet-ports" when "ports" is absent
so that newer DTBs with the preferred name work.
This matches the handling already present in qca8k-8xxx.c
Assisted-by: opencode:big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
v2: resend
drivers/net/dsa/qca/qca8k-leds.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/dsa/qca/qca8k-leds.c b/drivers/net/dsa/qca/qca8k-leds.c
index ef496e345a4e..0ada28377f46 100644
--- a/drivers/net/dsa/qca/qca8k-leds.c
+++ b/drivers/net/dsa/qca/qca8k-leds.c
@@ -457,6 +457,9 @@ qca8k_setup_led_ctrl(struct qca8k_priv *priv)
int ret;
ports = device_get_named_child_node(priv->dev, "ports");
+ if (!ports)
+ ports = device_get_named_child_node(priv->dev, "ethernet-ports");
+
if (!ports) {
dev_info(priv->dev, "No ports node specified in device tree!");
return 0;
--
2.54.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCHv2 net-next] net: dsa: qca8k: fall back to ethernet-ports node name for LEDs
2026-06-30 1:51 [PATCHv2 net-next] net: dsa: qca8k: fall back to ethernet-ports node name for LEDs Rosen Penev
@ 2026-07-02 20:43 ` Andrew Lunn
2026-07-03 6:14 ` Paolo Abeni
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2026-07-02 20:43 UTC (permalink / raw)
To: Rosen Penev
Cc: netdev, Vladimir Oltean, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, open list
On Mon, Jun 29, 2026 at 06:51:37PM -0700, Rosen Penev wrote:
> The device tree binding allows both "ports" and "ethernet-ports" as
> the container node name. Try "ethernet-ports" when "ports" is absent
> so that newer DTBs with the preferred name work.
>
> This matches the handling already present in qca8k-8xxx.c
>
> Assisted-by: opencode:big-pickle
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCHv2 net-next] net: dsa: qca8k: fall back to ethernet-ports node name for LEDs
2026-06-30 1:51 [PATCHv2 net-next] net: dsa: qca8k: fall back to ethernet-ports node name for LEDs Rosen Penev
2026-07-02 20:43 ` Andrew Lunn
@ 2026-07-03 6:14 ` Paolo Abeni
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Abeni @ 2026-07-03 6:14 UTC (permalink / raw)
To: Rosen Penev, netdev
Cc: Andrew Lunn, Vladimir Oltean, David S. Miller, Eric Dumazet,
Jakub Kicinski, open list
On 6/30/26 3:51 AM, Rosen Penev wrote:
> The device tree binding allows both "ports" and "ethernet-ports" as
> the container node name. Try "ethernet-ports" when "ports" is absent
> so that newer DTBs with the preferred name work.
>
> This matches the handling already present in qca8k-8xxx.c
>
> Assisted-by: opencode:big-pickle
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Apparently the PW bot is still enjoying some PTO...
Applied, thanks!
/P
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-03 6:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-30 1:51 [PATCHv2 net-next] net: dsa: qca8k: fall back to ethernet-ports node name for LEDs Rosen Penev
2026-07-02 20:43 ` Andrew Lunn
2026-07-03 6:14 ` Paolo Abeni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.