All of lore.kernel.org
 help / color / mirror / Atom feed
From: phucduc.bui@gmail.com
To: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
	Nick Li <nick.li@foursemi.com>,
	Herve Codina <herve.codina@bootlin.com>
Cc: Support Opensource <support.opensource@diasemi.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>,
	Srinivas Kandagatla <srini@kernel.org>,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	Richard Fitzgerald <rf@opensource.cirrus.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
	Baojun Xu <baojun.xu@ti.com>, Sen Wang <sen@ti.com>,
	Oder Chiou <oder_chiou@realtek.com>,
	Linus Walleij <linusw@kernel.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	u.kleine-koenig@baylibre.com, Zhang Yi <zhangyi@everest-semi.com>,
	Marco Crivellari <marco.crivellari@suse.com>,
	Kees Cook <kees@kernel.org>, HyeongJun An <sammiee5311@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Qianfeng Rong <rongqianfeng@vivo.com>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	patches@opensource.cirrus.com,
	linux-mediatek@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH 05/27] ASoC: codecs: es9356: Use guard() for mutex locks
Date: Tue, 30 Jun 2026 13:34:27 +0700	[thread overview]
Message-ID: <20260630063449.503996-6-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20260630063449.503996-1-phucduc.bui@gmail.com>

From: bui duc phuc <phucduc.bui@gmail.com>

Clean up the code using guard() for mutex locks.
Merely code refactoring, and no behavior change.

Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
 sound/soc/codecs/es9356.c | 29 ++++++++++++++++-------------
 1 file changed, 16 insertions(+), 13 deletions(-)

diff --git a/sound/soc/codecs/es9356.c b/sound/soc/codecs/es9356.c
index 8db81d574624..8ef9e70a9316 100644
--- a/sound/soc/codecs/es9356.c
+++ b/sound/soc/codecs/es9356.c
@@ -7,6 +7,7 @@
 //
 
 #include <linux/device.h>
+#include <linux/cleanup.h>
 #include <linux/mod_devicetable.h>
 #include <linux/module.h>
 #include <linux/soundwire/sdw.h>
@@ -501,16 +502,19 @@ static int es9356_power_state(struct snd_soc_dai *dai, unsigned char ps, unsigne
 	}
 
 	/* power state changes are not independent across functions */
-	mutex_lock(&es9356->pde_lock);
-	ret = es9356_pde_transition_delay(es9356, func, pde_entity, ps?ps0:ps3);
-	if (ret) {
-		regmap_write(es9356->regmap,
-			SDW_SDCA_CTL(func, pde_entity, ES9356_SDCA_CTL_REQ_POWER_STATE, 0), ps?ps3:ps0);
-		es9356_pde_transition_delay(es9356, func, pde_entity, ps?ps3:ps0);
-	} else
-		dev_dbg(component->dev, "%s PDE is already %d\n", __func__, ps?ps0:ps3);
-
-	mutex_unlock(&es9356->pde_lock);
+	scoped_guard(mutex, &es9356->pde_lock) {
+		ret = es9356_pde_transition_delay(es9356, func, pde_entity, ps ? ps0 : ps3);
+		if (ret) {
+			regmap_write(es9356->regmap,
+				     SDW_SDCA_CTL(func, pde_entity,
+						  ES9356_SDCA_CTL_REQ_POWER_STATE, 0),
+				     ps ? ps3 : ps0);
+			es9356_pde_transition_delay(es9356, func, pde_entity, ps ? ps3 : ps0);
+		} else {
+			dev_dbg(component->dev, "%s PDE is already %d\n", __func__,
+				ps ? ps0 : ps3);
+		}
+	}
 
 	if (rate)
 		regmap_write(es9356->regmap,
@@ -1092,9 +1096,8 @@ static int es9356_sdca_dev_system_suspend(struct device *dev)
 {
 	struct es9356_sdw_priv *es9356 = dev_get_drvdata(dev);
 
-	mutex_lock(&es9356->disable_irq_lock);
-	es9356->disable_irq = true;
-	mutex_unlock(&es9356->disable_irq_lock);
+	scoped_guard(mutex, &es9356->disable_irq_lock)
+		es9356->disable_irq = true;
 
 	return es9356_sdca_dev_suspend(dev);
 }
-- 
2.43.0


  parent reply	other threads:[~2026-06-30  6:35 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30  6:34 [PATCH 00/27] ASoC: codecs: Use guard() for mutex & spin locks phucduc.bui
2026-06-30  6:34 ` [PATCH 01/27] ASoC: codecs: da7213: Use guard() for mutex locks phucduc.bui
2026-06-30  6:34 ` [PATCH 02/27] ASoC: codecs: da7219: " phucduc.bui
2026-06-30  6:34 ` [PATCH 03/27] ASoC: codecs: es8316: " phucduc.bui
2026-06-30  6:34 ` [PATCH 04/27] ASoC: codecs: es8326: " phucduc.bui
2026-06-30  6:34 ` phucduc.bui [this message]
2026-06-30  6:34 ` [PATCH 06/27] ASoC: codecs: fs210x: " phucduc.bui
2026-06-30  6:34 ` [PATCH 07/27] ASoC: codecs: hdac_hdmi: " phucduc.bui
2026-06-30  6:34 ` [PATCH 08/27] ASoC: codecs: hdmi-codec: " phucduc.bui
2026-06-30  6:34 ` [PATCH 09/27] ASoC: codecs: idt821034: " phucduc.bui
2026-06-30  7:28   ` Herve Codina
2026-06-30  9:14     ` Bui Duc Phuc
2026-06-30 13:28       ` Mark Brown
2026-06-30 13:50         ` Bui Duc Phuc
2026-06-30  6:34 ` [PATCH 10/27] ASoC: codecs: lpass-macro: " phucduc.bui
2026-06-30  6:34 ` [PATCH 11/27] ASoC: codecs: madera: " phucduc.bui
2026-06-30  6:34 ` [PATCH 12/27] ASoC: codecs: max98095: " phucduc.bui
2026-06-30  6:34 ` [PATCH 13/27] ASoC: codecs: mt6359-accdet: " phucduc.bui
2026-06-30  6:34 ` [PATCH 14/27] ASoC: codecs: pcm512x: " phucduc.bui
2026-06-30  6:34 ` [PATCH 15/27] ASoC: codecs: pcm6240: " phucduc.bui
2026-06-30  6:34 ` [PATCH 16/27] ASoC: codecs: peb2466: " phucduc.bui
2026-06-30  6:54   ` Herve Codina
2026-06-30  6:34 ` [PATCH 17/27] ASoC: codecs: rt5514-spi: " phucduc.bui
2026-06-30  6:34 ` [PATCH 18/27] ASoC: codecs: rt5645: " phucduc.bui
2026-06-30  6:34 ` [PATCH 19/27] ASoC: codecs: rt5665: " phucduc.bui
2026-06-30  6:34 ` [PATCH 20/27] ASoC: codecs: rt5668: " phucduc.bui
2026-06-30  6:34 ` [PATCH 21/27] ASoC: codecs: rt5677: " phucduc.bui
2026-06-30  6:34 ` [PATCH 22/27] ASoC: codecs: rt5682: " phucduc.bui
2026-06-30  6:34 ` [PATCH 23/27] ASoC: codecs: rt700: " phucduc.bui
2026-06-30  6:34 ` [PATCH 24/27] ASoC: codecs: rt711: " phucduc.bui
2026-06-30  6:34 ` [PATCH 25/27] ASoC: codecs: rt712: " phucduc.bui
2026-06-30  6:34 ` [PATCH 26/27] ASoC: codecs: rt721: " phucduc.bui
2026-06-30  6:34 ` [PATCH 27/27] ASoC: codecs: rt722: " phucduc.bui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260630063449.503996-6-phucduc.bui@gmail.com \
    --to=phucduc.bui@gmail.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=arnd@arndb.de \
    --cc=baojun.xu@ti.com \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=herve.codina@bootlin.com \
    --cc=kees@kernel.org \
    --cc=kevin-lu@ti.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=marco.crivellari@suse.com \
    --cc=matthias.bgg@gmail.com \
    --cc=nick.li@foursemi.com \
    --cc=oder_chiou@realtek.com \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=rf@opensource.cirrus.com \
    --cc=rongqianfeng@vivo.com \
    --cc=sammiee5311@gmail.com \
    --cc=sen@ti.com \
    --cc=shenghao-ding@ti.com \
    --cc=srini@kernel.org \
    --cc=support.opensource@diasemi.com \
    --cc=tiwai@suse.com \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=zhangyi@everest-semi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.